From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-15714-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 5831 invoked by alias); 17 May 2002 21:43:50 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 5781 invoked from network); 17 May 2002 21:43:46 -0000
Received: from unknown (HELO localhost.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 17 May 2002 21:43:46 -0000
Received: from cygnus.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id C36A53E98; Fri, 17 May 2002 17:43:54 -0400 (EDT)
Message-ID: <3CE5799A.30605@cygnus.com>
Date: Fri, 17 May 2002 14:43:00 -0000
From: Andrew Cagney <ac131313@cygnus.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0rc1) Gecko/20020429
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC/MI] Renumber enum mi_cmd_result
References: <Pine.GSO.4.33.0205171417280.2236-100000@makita.cygnus.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-05/txt/msg00762.txt.bz2

> Hi,
> 
> I've been looking over Apple's MI changes, so expect to see quite a few
> questions/changes/patches/debates/documentation updates/etc in the coming
> weeks on MI.
> 
> This simple patch renumbers enum mi_cmd_result so that it starts at one
> instead of zero. This is necessary because MI_CMD_DONE would be
> indistinguishable from an error condition (both would return zero to
> catch_errors).
> 
> I have run the testsuite before and after this change, and it produces no
> differences.
> 
> (Okay, this is almost too simple to leave by itself, but, gotta start
> somewhere!)
> 
> Keith
> 
> ChangeLog
> 2002-05-17  Keith Seitz  <keiths@redhat.com>
> 
>         From Jim Ingham <jingham at apple dot com>:
>         * mi-cmds.h (enum mi_cmd_result): Start numbering at one instead
>         of zero so that errors can be distinguished from other status
>         returns.
> 
Keith,

Check catch_exceptions().  The whole catch_errors() argument problem has 
been fixed.  I'd consider a switch to catch_exceptions obvious and I can 
see only one call.

Andrew