Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Nick Clifton <nickc@cambridge.redhat.com>
Cc: gdb-patches@sources.redhat.com, Richard.Earnshaw@arm.com
Subject: Re: Add support for target switches in simulator
Date: Fri, 17 May 2002 11:32:00 -0000	[thread overview]
Message-ID: <3CE54CDD.6070001@cygnus.com> (raw)
In-Reply-To: <m3vg9o5aql.fsf@north-pole.nickc.cambridge.redhat.com>

> Index: include/remote-sim.h
> ===================================================================
> RCS file: /cvs/src/src/include/remote-sim.h,v
> retrieving revision 1.4
> diff -c -3 -p -w -r1.4 remote-sim.h
> *** include/remote-sim.h	14 Mar 2001 02:27:43 -0000	1.4
> --- include/remote-sim.h	16 May 2002 16:07:49 -0000
> *************** void sim_set_profile_size PARAMS ((int n
> *** 346,351 ****
> --- 346,362 ----
>      multi-cpu simulators. */
>   
>   void sim_kill PARAMS ((SIM_DESC sd));
> + 
> + #ifdef SIM_TARGET_SWITCHES
> +   /* Parse the command line, extracting any target specific switches
> +      before the generic simulator code gets a chance to complain
> +      about them.  Returns the adjusted value of argc.  */
> + int sim_target_parse_command_line PARAMS ((int, char **));
> + 
> +   /* Display a list of target specific switches supported by this
> +      target.  */
> + void sim_target_display_usage PARAMS ((void));
> + #endif
>   
>   #ifdef __cplusplus
>   }

Nick,

I can understand you adding the interface here (that is where all the 
others are).  However, see:
http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gdb

(in hindsight, the functions should be just moved and not renamed, and 
I'm not asking you to do any of that).

I think a better place would be a new file sim/common/sim-run.h to 
indicate that this is part of the interface that run.c uses.

As for converting Arm to use the new framework, I would recommend 
creating a change-request :-)

Andrew



  parent reply	other threads:[~2002-05-17 18:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-09  3:09 Add support for RedBoot SWIs to ARM Simulator Nick Clifton
2002-05-09  3:22 ` Richard Earnshaw
2002-05-09  4:00   ` Nick Clifton
2002-05-09  4:11     ` Richard Earnshaw
2002-05-16  9:16       ` Add support for target switches in simulator Nick Clifton
2002-05-16  9:25         ` Richard Earnshaw
2002-05-17  1:58           ` Nick Clifton
2002-05-17  5:37             ` Richard Earnshaw
2002-05-17  6:46               ` Nick Clifton
2002-05-17 10:17                 ` Andrew Cagney
2002-05-17  7:33             ` Frank Ch. Eigler
2002-05-17 10:29             ` Andrew Cagney
2002-05-16  9:36         ` Frank Ch. Eigler
2002-05-16 11:08         ` Michael Snyder
2002-05-17 11:32         ` Andrew Cagney [this message]
2002-05-20  6:11           ` Nick Clifton
2002-05-20  7:12             ` Andrew Cagney
2002-05-20  7:19             ` Richard Earnshaw
2002-05-20  7:26               ` Nick Clifton
2002-05-09  7:35     ` Add support for RedBoot SWIs to ARM Simulator Frank Ch. Eigler
2002-05-20  7:49 Add support for target switches in simulator Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CE54CDD.6070001@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=nickc@cambridge.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox