From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6990 invoked by alias); 17 May 2002 18:32:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6968 invoked from network); 17 May 2002 18:32:53 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 17 May 2002 18:32:53 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id C8D563E98; Fri, 17 May 2002 14:33:01 -0400 (EDT) Message-ID: <3CE54CDD.6070001@cygnus.com> Date: Fri, 17 May 2002 11:32:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0rc1) Gecko/20020429 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Nick Clifton Cc: gdb-patches@sources.redhat.com, Richard.Earnshaw@arm.com Subject: Re: Add support for target switches in simulator References: <200205091111.MAA22264@cam-mail2.cambridge.arm.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-05/txt/msg00743.txt.bz2 > Index: include/remote-sim.h > =================================================================== > RCS file: /cvs/src/src/include/remote-sim.h,v > retrieving revision 1.4 > diff -c -3 -p -w -r1.4 remote-sim.h > *** include/remote-sim.h 14 Mar 2001 02:27:43 -0000 1.4 > --- include/remote-sim.h 16 May 2002 16:07:49 -0000 > *************** void sim_set_profile_size PARAMS ((int n > *** 346,351 **** > --- 346,362 ---- > multi-cpu simulators. */ > > void sim_kill PARAMS ((SIM_DESC sd)); > + > + #ifdef SIM_TARGET_SWITCHES > + /* Parse the command line, extracting any target specific switches > + before the generic simulator code gets a chance to complain > + about them. Returns the adjusted value of argc. */ > + int sim_target_parse_command_line PARAMS ((int, char **)); > + > + /* Display a list of target specific switches supported by this > + target. */ > + void sim_target_display_usage PARAMS ((void)); > + #endif > > #ifdef __cplusplus > } Nick, I can understand you adding the interface here (that is where all the others are). However, see: http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gdb (in hindsight, the functions should be just moved and not renamed, and I'm not asking you to do any of that). I think a better place would be a new file sim/common/sim-run.h to indicate that this is part of the interface that run.c uses. As for converting Arm to use the new framework, I would recommend creating a change-request :-) Andrew