From: Andrew Cagney <ac131313@cygnus.com>
To: Richard.Earnshaw@arm.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch:arm] Don't use NUM_PSEUDO_REGS in arm_gdbarch_init()
Date: Wed, 24 Apr 2002 11:23:00 -0000 [thread overview]
Message-ID: <3CC6F82B.4010007@cygnus.com> (raw)
In-Reply-To: <200204221107.MAA06332@cam-mail2.cambridge.arm.com>
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
> Argh! As you will see from the comment, I'd already fixed a similar
> problem to avoid using SIZEOF_FRAME_SAVED_REGS, but missed that part. Can
> you update the comment as well?
>
> /* We can't use SIZEOF_FRAME_SAVED_REGS here, since that still
> references the old architecture vector, not the one we are
> building here. */
>
(and NUM_REGS). I committed the attached.
Andrew
[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 852 bytes --]
Wed Apr 24 14:22:21 2002 Andrew Cagney <cagney@redhat.com>
* arm-tdep.c (arm_gdbarch_init): Add comment that NUM_REGS nor
NUM_PSEUDO_REGS can be used.
Index: arm-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-tdep.c,v
retrieving revision 1.52
diff -c -r1.52 arm-tdep.c
*** arm-tdep.c 23 Apr 2002 18:10:06 -0000 1.52
--- arm-tdep.c 24 Apr 2002 18:21:17 -0000
***************
*** 3035,3040 ****
--- 3035,3043 ----
if (prologue_cache.saved_regs != NULL)
xfree (prologue_cache.saved_regs);
+ /* We can't use NUM_REGS nor NUM_PSEUDO_REGS here, since that still
+ references the old architecture vector, not the one we are
+ building here. */
prologue_cache.saved_regs = (CORE_ADDR *)
xcalloc (1, (sizeof (CORE_ADDR)
* (gdbarch_num_regs (gdbarch)
prev parent reply other threads:[~2002-04-24 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-20 20:25 Andrew Cagney
2002-04-22 4:08 ` Richard Earnshaw
2002-04-22 6:59 ` Andrew Cagney
2002-04-24 11:23 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CC6F82B.4010007@cygnus.com \
--to=ac131313@cygnus.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox