From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13567 invoked by alias); 24 Apr 2002 18:23:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13560 invoked from network); 24 Apr 2002 18:23:40 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 24 Apr 2002 18:23:40 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 4D8343D26; Wed, 24 Apr 2002 14:23:39 -0400 (EDT) Message-ID: <3CC6F82B.4010007@cygnus.com> Date: Wed, 24 Apr 2002 11:23:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.9) Gecko/20020328 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Richard.Earnshaw@arm.com Cc: gdb-patches@sources.redhat.com Subject: Re: [patch:arm] Don't use NUM_PSEUDO_REGS in arm_gdbarch_init() References: <200204221107.MAA06332@cam-mail2.cambridge.arm.com> Content-Type: multipart/mixed; boundary="------------000904050405060700010609" X-SW-Source: 2002-04/txt/msg00959.txt.bz2 This is a multi-part message in MIME format. --------------000904050405060700010609 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 402 > Argh! As you will see from the comment, I'd already fixed a similar > problem to avoid using SIZEOF_FRAME_SAVED_REGS, but missed that part. Can > you update the comment as well? > > /* We can't use SIZEOF_FRAME_SAVED_REGS here, since that still > references the old architecture vector, not the one we are > building here. */ > (and NUM_REGS). I committed the attached. Andrew --------------000904050405060700010609 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 852 Wed Apr 24 14:22:21 2002 Andrew Cagney * arm-tdep.c (arm_gdbarch_init): Add comment that NUM_REGS nor NUM_PSEUDO_REGS can be used. Index: arm-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/arm-tdep.c,v retrieving revision 1.52 diff -c -r1.52 arm-tdep.c *** arm-tdep.c 23 Apr 2002 18:10:06 -0000 1.52 --- arm-tdep.c 24 Apr 2002 18:21:17 -0000 *************** *** 3035,3040 **** --- 3035,3043 ---- if (prologue_cache.saved_regs != NULL) xfree (prologue_cache.saved_regs); + /* We can't use NUM_REGS nor NUM_PSEUDO_REGS here, since that still + references the old architecture vector, not the one we are + building here. */ prologue_cache.saved_regs = (CORE_ADDR *) xcalloc (1, (sizeof (CORE_ADDR) * (gdbarch_num_regs (gdbarch) --------------000904050405060700010609--