Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Richard.Earnshaw@arm.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch:arm] Don't use NUM_PSEUDO_REGS in arm_gdbarch_init()
Date: Mon, 22 Apr 2002 06:59:00 -0000	[thread overview]
Message-ID: <3CC41723.70603@cygnus.com> (raw)
In-Reply-To: <200204221107.MAA06332@cam-mail2.cambridge.arm.com>

> Hello,
>> 
>> The macro NUM_PSEUDO_REGS refers to ``current_gdbarch'' and not 
>> ``gdbarch''.  Hence the equation in the patch was picking up the number 
>> of pseudo-registers from the previously selected architecture (which may 
>> not even be ARM), outch!  No wonder macro's are bad :-)
>> 
>> The attached calls gdbarch_num_pseudo_regs() directly with the correct 
>> architecture.  (It also fixes a core dump that my next patch will cause ...)
>> 
>> Committed as fairly obvious.
>> 
>> Andrew
>> 
>> 2002-04-20  Andrew Cagney  <ac131313@redhat.com>
>> 
>> * arm-tdep.c (arm_gdbarch_init): Use gdbarch_num_pseudo_regs
>> instead of NUM_PSEUDO_REGS.
> 
> 
> Argh! As you will see from the comment, I'd already fixed a similar 
> problem to avoid using SIZEOF_FRAME_SAVED_REGS, but missed that part.  Can 
> you update the comment as well?

M'kay.

>   /* We can't use SIZEOF_FRAME_SAVED_REGS here, since that still
>      references the old architecture vector, not the one we are
>      building here.  */

BTW, once the patch:
http://sources.redhat.com/ml/gdb-patches/2002-04/msg00711.html
goes through the problem should largely ``go away''.

Andrew


  reply	other threads:[~2002-04-22 13:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-20 20:25 Andrew Cagney
2002-04-22  4:08 ` Richard Earnshaw
2002-04-22  6:59   ` Andrew Cagney [this message]
2002-04-24 11:23   ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CC41723.70603@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox