[RFA] gdbserver warnings

[RFA] gdbserver warnings

[Michal Ludvig]

[-- Attachment #1: Type: text/plain, Size: 880 bytes --]

Hi,
Now only two simple issues things in gdbserver to compile cleanly. First 
patch prevents:
linux-low.c: In function `regsets_store_inferior_registers':
linux-low.c:424: warning: cast from pointer to integer of different size
on x86-64 where sizeof(void*) != sizeof(int). Why did you cast the last 
argument from pointer to integer? Manpage says it should be a void*... 
But I didn't test it on other archs...

The second one prevents:
regcache.h:26: warning: `struct inferior_info' declared inside parameter 
list

2002-04-24  Michal Ludvig  <mludvig@suse.cz>

         * gdbserver/linux-low.c (regsets_fetch_inferior_registers),
         (regsets_store_inferior_registers): Removed cast to int from
         ptrace() calls.
         * gdbserver/regcache.h: Include server.h.


Michal Ludvig
-- 
* SuSE CR, s.r.o     * mludvig@suse.cz
* +420 2 9654 5373   * http://www.suse.cz

[-- Attachment #2: gdbserver1.diff --]
[-- Type: text/plain, Size: 1695 bytes --]

Index: linux-low.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/linux-low.c,v
retrieving revision 1.15
diff -c -3 -p -r1.15 linux-low.c
*** linux-low.c	20 Apr 2002 17:04:09 -0000	1.15
--- linux-low.c	24 Apr 2002 11:53:52 -0000
*************** regsets_fetch_inferior_registers (void)
*** 372,378 ****
  	}
  
        buf = malloc (regset->size);
!       res = ptrace (regset->get_request, inferior_pid, 0, (int) buf);
        if (res < 0)
  	{
  	  if (errno == EIO)
--- 372,378 ----
  	}
  
        buf = malloc (regset->size);
!       res = ptrace (regset->get_request, inferior_pid, 0, buf);
        if (res < 0)
  	{
  	  if (errno == EIO)
*************** regsets_store_inferior_registers (void)
*** 421,427 ****
  
        buf = malloc (regset->size);
        regset->fill_function (buf);
!       res = ptrace (regset->set_request, inferior_pid, 0, (int) buf);
        if (res < 0)
  	{
  	  if (errno == EIO)
--- 421,427 ----
  
        buf = malloc (regset->size);
        regset->fill_function (buf);
!       res = ptrace (regset->set_request, inferior_pid, 0, buf);
        if (res < 0)
  	{
  	  if (errno == EIO)
Index: regcache.h
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/regcache.h,v
retrieving revision 1.3
diff -c -3 -p -r1.3 regcache.h
*** regcache.h	20 Apr 2002 17:22:48 -0000	1.3
--- regcache.h	24 Apr 2002 11:53:52 -0000
***************
*** 21,26 ****
--- 21,28 ----
  #ifndef REGCACHE_H
  #define REGCACHE_H
  
+ #include <server.h>
+ 
  /* Create a new register cache for INFERIOR.  */
  
  void create_register_cache (struct inferior_info *inferior);

Re: [RFA] gdbserver warnings

[Daniel Jacobowitz]

On Wed, Apr 24, 2002 at 02:03:49PM +0200, Michal Ludvig wrote:
> Hi,
> Now only two simple issues things in gdbserver to compile cleanly. First 
> patch prevents:
> linux-low.c: In function `regsets_store_inferior_registers':
> linux-low.c:424: warning: cast from pointer to integer of different size
> on x86-64 where sizeof(void*) != sizeof(int). Why did you cast the last 
> argument from pointer to integer? Manpage says it should be a void*... 
> But I didn't test it on other archs...

Interesting.  I got that from i386-linux-nat.c, IIRC:
  if (ptrace (PTRACE_GETREGS, tid, 0, (int) &regs) < 0)

Might want to fix that one too.

> The second one prevents:
> regcache.h:26: warning: `struct inferior_info' declared inside parameter 
> list
> 
> 2002-04-24  Michal Ludvig  <mludvig@suse.cz>
> 
>         * gdbserver/linux-low.c (regsets_fetch_inferior_registers),
>         (regsets_store_inferior_registers): Removed cast to int from
>         ptrace() calls.

This bit is OK.

>         * gdbserver/regcache.h: Include server.h.

Sorry, I thought this warning had been introduced in my local copy, so
the fix was tied up with all my other patches... Please add
"struct inferior_info;" instead of "#include "server.h"".  Approved
with that change.


-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer