From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2164 invoked by alias); 24 Apr 2002 14:22:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2038 invoked from network); 24 Apr 2002 14:22:19 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 24 Apr 2002 14:22:19 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 170Nev-0001l3-00; Wed, 24 Apr 2002 10:22:13 -0400 Date: Wed, 24 Apr 2002 07:22:00 -0000 From: Daniel Jacobowitz To: Michal Ludvig Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] gdbserver warnings Message-ID: <20020424102213.A6310@nevyn.them.org> Mail-Followup-To: Michal Ludvig , gdb-patches@sources.redhat.com References: <3CC69F25.3040704@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3CC69F25.3040704@suse.cz> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-04/txt/msg00936.txt.bz2 On Wed, Apr 24, 2002 at 02:03:49PM +0200, Michal Ludvig wrote: > Hi, > Now only two simple issues things in gdbserver to compile cleanly. First > patch prevents: > linux-low.c: In function `regsets_store_inferior_registers': > linux-low.c:424: warning: cast from pointer to integer of different size > on x86-64 where sizeof(void*) != sizeof(int). Why did you cast the last > argument from pointer to integer? Manpage says it should be a void*... > But I didn't test it on other archs... Interesting. I got that from i386-linux-nat.c, IIRC: if (ptrace (PTRACE_GETREGS, tid, 0, (int) ®s) < 0) Might want to fix that one too. > The second one prevents: > regcache.h:26: warning: `struct inferior_info' declared inside parameter > list > > 2002-04-24 Michal Ludvig > > * gdbserver/linux-low.c (regsets_fetch_inferior_registers), > (regsets_store_inferior_registers): Removed cast to int from > ptrace() calls. This bit is OK. > * gdbserver/regcache.h: Include server.h. Sorry, I thought this warning had been introduced in my local copy, so the fix was tied up with all my other patches... Please add "struct inferior_info;" instead of "#include "server.h"". Approved with that change. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer