Re: [RFA] Fix logic error suppressing attach.exp tests

Re: [RFA] Fix logic error suppressing attach.exp tests

[Michael Elizabeth Chastain]

I proofread this and it looks good to me, with one gotcha: you need to
add "2002" to the copyright dates.

I tested this on:

  target=native
  host=i686-pc-linux-gnu%rh-7.2
  gdb=HEAD%20020226
  gcc=2.95.3, 3.0.4, gcc-3_1-branch%20020226, HEAD%20020226
  glibc=vendor
  goption=-gdwarf-2, -gstabs+

The results are flawless: all PASS on all configurations.

I don't have approval authority in testsuite/gdb.base but I like this patch.
Can anyone test it on more targets and hosts?

Michael C

===

  2002-02-28  Fred Fish  <fnf@redhat.com>

	* gdb.base/attach.exp: Fix logic error that was suppressing this
	test for all non hppa*-*-hpux* targets, instead of the hp target.
	Move comments closer to the suppression point.

Re: [RFA] Fix logic error suppressing attach.exp tests

[Fred Fish]

> I don't have approval authority in testsuite/gdb.base but I like this patch.
> Can anyone test it on more targets and hosts?

I've not gotten any explicit approval for this patch yet.  It seems
like a pretty obvious fix.  I'm tempted to just check it in under the
"obvious typo fix" rule.

-Fred

Re: [RFA] Fix logic error suppressing attach.exp tests

[Michael Snyder]

Fred Fish wrote:
> 
> > I don't have approval authority in testsuite/gdb.base but I like this patch.
> > Can anyone test it on more targets and hosts?
> 
> I've not gotten any explicit approval for this patch yet.  It seems
> like a pretty obvious fix.  I'm tempted to just check it in under the
> "obvious typo fix" rule.

Oh, heck, I'll put on my "mighty universal check-in" hat and give you
approval.
;-)

Michael

[RFA] Fix logic error suppressing attach.exp tests

[Fred Fish]

2002-02-28  Fred Fish  <fnf@redhat.com>

	* gdb.base/attach.exp: Fix logic error that was suppressing this
	test for all non hppa*-*-hpux* targets, instead of the hp target.
	Move comments closer to the suppression point.

Index: gdb.base/attach.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/attach.exp,v
retrieving revision 1.2
diff -c -p -r1.2 attach.exp
*** attach.exp	2001/03/06 08:21:50	1.2
--- attach.exp	2002/02/28 21:11:58
***************
*** 17,42 ****
  # Please email any bugs, comments, and/or additions to this file to:
  # bug-gdb@prep.ai.mit.edu
  
- # On HP-UX 11.0, this test is causing a process running
- # the program "attach" to be left around spinning.
- # Until we figure out why, I am commenting out the test
- # to avoid polluting tiamat (our 11.0 nightly test machine)
- # with these processes. RT
- #
- # Setting the magic bit in the target app should work.
- # I added a "kill", and also a test for the R3 register
- #  warning.           JB
- # 
  if $tracelevel then {
  	strace $tracelevel
  	}
  
  set prms_id 0
  set bug_id 0
- 
  
! if { ![istarget "hppa*-*-hpux*"] } {
!     #setup_xfail "*-*-*"
      return 0
  }
  
--- 17,37 ----
  # Please email any bugs, comments, and/or additions to this file to:
  # bug-gdb@prep.ai.mit.edu
  
  if $tracelevel then {
  	strace $tracelevel
  	}
  
  set prms_id 0
  set bug_id 0
  
! # On HP-UX 11.0, this test is causing a process running the program
! # "attach" to be left around spinning.  Until we figure out why, I am
! # commenting out the test to avoid polluting tiamat (our 11.0 nightly
! # test machine) with these processes. RT
! #
! # Setting the magic bit in the target app should work.  I added a
! # "kill", and also a test for the R3 register warning.  JB
! if { [istarget "hppa*-*-hpux*"] } {
      return 0
  }