From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12207 invoked by alias); 1 Mar 2002 01:48:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12036 invoked from network); 1 Mar 2002 01:48:38 -0000 Received: from unknown (HELO duracef.shout.net) (204.253.184.12) by sources.redhat.com with SMTP; 1 Mar 2002 01:48:38 -0000 Received: (from mec@localhost) by duracef.shout.net (8.11.6/8.11.6) id g211mas19189; Thu, 28 Feb 2002 19:48:36 -0600 Date: Thu, 28 Feb 2002 17:48:00 -0000 From: Michael Elizabeth Chastain Message-Id: <200203010148.g211mas19189@duracef.shout.net> To: fnf@redhat.com Subject: Re: [RFA] Fix logic error suppressing attach.exp tests Cc: gdb-patches@sources.redhat.com X-SW-Source: 2002-02/txt/msg00753.txt.bz2 I proofread this and it looks good to me, with one gotcha: you need to add "2002" to the copyright dates. I tested this on: target=native host=i686-pc-linux-gnu%rh-7.2 gdb=HEAD%20020226 gcc=2.95.3, 3.0.4, gcc-3_1-branch%20020226, HEAD%20020226 glibc=vendor goption=-gdwarf-2, -gstabs+ The results are flawless: all PASS on all configurations. I don't have approval authority in testsuite/gdb.base but I like this patch. Can anyone test it on more targets and hosts? Michael C === 2002-02-28 Fred Fish * gdb.base/attach.exp: Fix logic error that was suppressing this test for all non hppa*-*-hpux* targets, instead of the hp target. Move comments closer to the suppression point.