[patch/rfc] Delete floatformat_arm_ext

[patch/rfc] Delete floatformat_arm_ext

[Andrew Cagney]

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

Hello,

The attached deletes floatformat_arm_ext from include/floatformat.h and 
libiberty/floatformat.c.  As far as I know nothing uses it.  GDB stopped 
using it some time ago.

It has been replaced with the far more useful:

const struct floatformat floatformat_arm_ext_big;
const struct floatformat floatformat_arm_ext_littlebyte_bigword;

Any comments?  If not I'll commit it in a few days.
Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 1672 bytes --]

Index: ./include/ChangeLog
2002-02-23  Andrew Cagney  <ac131313@redhat.com>

	* floatformat.h (floatformat_arm_ext): Delete declaration.

Index: ./libiberty/ChangeLog
2002-02-23  Andrew Cagney  <ac131313@redhat.com>

	* floatformat.c (floatformat_arm_ext_big): Delete definition.

Index: ./include/floatformat.h
===================================================================
RCS file: /cvs/src/src/include/floatformat.h,v
retrieving revision 1.4
diff -u -r1.4 floatformat.h
--- floatformat.h	2001/08/21 00:20:05	1.4
+++ floatformat.h	2002/02/24 03:51:10
@@ -96,7 +96,6 @@
 extern const struct floatformat floatformat_i960_ext;
 extern const struct floatformat floatformat_m88110_ext;
 extern const struct floatformat floatformat_m88110_harris_ext;
-extern const struct floatformat floatformat_arm_ext; /* deprecated. */
 extern const struct floatformat floatformat_arm_ext_big;
 extern const struct floatformat floatformat_arm_ext_littlebyte_bigword;
 /* IA-64 Floating Point register spilt into memory.  */
Index: ./libiberty/floatformat.c
===================================================================
RCS file: /cvs/src/src/libiberty/floatformat.c,v
retrieving revision 1.5
diff -u -r1.5 floatformat.c
--- floatformat.c	2001/08/21 00:20:07	1.5
+++ floatformat.c	2002/02/24 03:51:16
@@ -103,13 +103,6 @@
   floatformat_intbit_no,
   "floatformat_m88110_ext_harris"
 };
-const struct floatformat floatformat_arm_ext =
-{
-  /* Bits 1 to 16 are unused.  */
-  floatformat_big, 96, 0, 17, 15, 0x3fff, 0x7fff, 32, 64,
-  floatformat_intbit_yes,
-  "floatformat_arm_ext"
-};
 const struct floatformat floatformat_arm_ext_big =
 {
   /* Bits 1 to 16 are unused.  */

Re: [patch/rfc] Delete floatformat_arm_ext

[DJ Delorie]

> The attached deletes floatformat_arm_ext from include/floatformat.h and 
> libiberty/floatformat.c.  As far as I know nothing uses it.  GDB stopped 
> using it some time ago.

In general, I'm opposed to changes that reduce backward compatibility.
*How* long ago did someone actually use it?  What's the chance of that
version still being in use by someone?  Are there any bad side-effects
if we just leave it in for historical reasons?

Re: [patch/rfc] Delete floatformat_arm_ext

[Andrew Cagney]

[I messed up a to line, original post at end]

> The attached deletes floatformat_arm_ext from include/floatformat.h and 
>> libiberty/floatformat.c.  As far as I know nothing uses it.  GDB stopped 
>> using it some time ago.
> 
> 
> In general, I'm opposed to changes that reduce backward compatibility.
> *How* long ago did someone actually use it?  What's the chance of that
> version still being in use by someone?  Are there any bad side-effects
> if we just leave it in for historical reasons?

The only useage of that floatformat that I'm aware of was removed 
2001-08 by Andrew Cagney <ac131313@redhat.com>.

The single format wasn't sufficient for a program trying to correctly 
manipulate both big and little endian Arm floating points - hence the 
two new formats.

GDB has a strong preference for flushing code it no longer needs.  It 
has the unfortunate habbit of rearing its head at later inopportune moments.

enjoy,
Andrew


----------------

> Hello,
> 
> The attached deletes floatformat_arm_ext from include/floatformat.h and libiberty/floatformat.c.  As far as I know nothing uses it.  GDB stopped using it some time ago.
> 
> It has been replaced with the far more useful:
> 
> const struct floatformat floatformat_arm_ext_big;
> const struct floatformat floatformat_arm_ext_littlebyte_bigword;
> 
> Any comments?  If not I'll commit it in a few days.
> Andrew
> 
> 
> 
> Index: ./include/ChangeLog
> 2002-02-23  Andrew Cagney  <ac131313@redhat.com>
> 
> * floatformat.h (floatformat_arm_ext): Delete declaration.
> 
> Index: ./libiberty/ChangeLog
> 2002-02-23  Andrew Cagney  <ac131313@redhat.com>
> 
> * floatformat.c (floatformat_arm_ext_big): Delete definition.
> 
> Index: ./include/floatformat.h
> ===================================================================
> RCS file: /cvs/src/src/include/floatformat.h,v
> retrieving revision 1.4
> diff -u -r1.4 floatformat.h
> --- floatformat.h	2001/08/21 00:20:05	1.4
> +++ floatformat.h	2002/02/24 03:51:10
> @@ -96,7 +96,6 @@
>  extern const struct floatformat floatformat_i960_ext;
>  extern const struct floatformat floatformat_m88110_ext;
>  extern const struct floatformat floatformat_m88110_harris_ext;
> -extern const struct floatformat floatformat_arm_ext; /* deprecated. */
>  extern const struct floatformat floatformat_arm_ext_big;
>  extern const struct floatformat floatformat_arm_ext_littlebyte_bigword;
>  /* IA-64 Floating Point register spilt into memory.  */
> Index: ./libiberty/floatformat.c
> ===================================================================
> RCS file: /cvs/src/src/libiberty/floatformat.c,v
> retrieving revision 1.5
> diff -u -r1.5 floatformat.c
> --- floatformat.c	2001/08/21 00:20:07	1.5
> +++ floatformat.c	2002/02/24 03:51:16
> @@ -103,13 +103,6 @@
>    floatformat_intbit_no,
>    "floatformat_m88110_ext_harris"
>  };
> -const struct floatformat floatformat_arm_ext =
> -{
> -  /* Bits 1 to 16 are unused.  */
> -  floatformat_big, 96, 0, 17, 15, 0x3fff, 0x7fff, 32, 64,
> -  floatformat_intbit_yes,
> -  "floatformat_arm_ext"
> -};
>  const struct floatformat floatformat_arm_ext_big =
>  {
>    /* Bits 1 to 16 are unused.  */
> 

Re: [patch/rfc] Delete floatformat_arm_ext

[DJ Delorie]

> The single format wasn't sufficient for a program trying to correctly 
> manipulate both big and little endian Arm floating points - hence the 
> two new formats.

Is it safe to say that the code you're removing never actually worked,
then?  If so, then there shouldn't be any legacy code relying on it,
right?

> GDB has a strong preference for flushing code it no longer needs.
> It has the unfortunate habbit of rearing its head at later
> inopportune moments.

Perhaps, but libiberty is used by more than just gdb, so I have to be
extra careful about backwards compatibility.  Just yesterday someone
was asking about using libiberty in their own program.

Re: [patch/rfc] Delete floatformat_arm_ext

[Andrew Cagney]

> The single format wasn't sufficient for a program trying to correctly 
>> manipulate both big and little endian Arm floating points - hence the 
>> two new formats.
> 
> 
> Is it safe to say that the code you're removing never actually worked,
> then?  If so, then there shouldn't be any legacy code relying on it,
> right?

Er, actually, the code I ``fixed'' didn't use it either!  The format was 
added '95 but I've had no luck finding anything that used it.

enjoy,
Andrew

Re: [patch/rfc] Delete floatformat_arm_ext

[DJ Delorie]

> Er, actually, the code I ``fixed'' didn't use it either!  The format was 
> added '95 but I've had no luck finding anything that used it.

Hrmph.  Approved, then.

Re: [patch/rfc] Delete floatformat_arm_ext

[Andrew Cagney]

> Er, actually, the code I ``fixed'' didn't use it either!  The format was 
>> added '95 but I've had no luck finding anything that used it.
> 
> 
> Hrmph.  Approved, then.
> 


Committed to trunk.


> Index: ./include/ChangeLog
> 2002-02-23  Andrew Cagney  <ac131313@redhat.com>
> 
> * floatformat.h (floatformat_arm_ext): Delete declaration.
> 
> Index: ./libiberty/ChangeLog
> 2002-02-23  Andrew Cagney  <ac131313@redhat.com>
> 
> * floatformat.c (floatformat_arm_ext_big): Delete definition.

Andrew