From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14613 invoked by alias); 24 Feb 2002 05:33:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14492 invoked from network); 24 Feb 2002 05:33:11 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.135.44) by sources.redhat.com with SMTP; 24 Feb 2002 05:33:11 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id A61F73D51; Sun, 24 Feb 2002 00:33:08 -0500 (EST) Message-ID: <3C787B14.7080704@cygnus.com> Date: Sat, 23 Feb 2002 21:33:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.8) Gecko/20020210 X-Accept-Language: en-us MIME-Version: 1.0 To: DJ Delorie Cc: gdb-patches@sources.redhat.com, binutils@sources.redhat.com, gcc-patches@gcc.gnu.org Subject: Re: [patch/rfc] Delete floatformat_arm_ext References: <3C7864AB.1060900@cygnus.com> <200202240447.g1O4ldb05280@envy.delorie.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-02/txt/msg00666.txt.bz2 [I messed up a to line, original post at end] > The attached deletes floatformat_arm_ext from include/floatformat.h and >> libiberty/floatformat.c. As far as I know nothing uses it. GDB stopped >> using it some time ago. > > > In general, I'm opposed to changes that reduce backward compatibility. > *How* long ago did someone actually use it? What's the chance of that > version still being in use by someone? Are there any bad side-effects > if we just leave it in for historical reasons? The only useage of that floatformat that I'm aware of was removed 2001-08 by Andrew Cagney . The single format wasn't sufficient for a program trying to correctly manipulate both big and little endian Arm floating points - hence the two new formats. GDB has a strong preference for flushing code it no longer needs. It has the unfortunate habbit of rearing its head at later inopportune moments. enjoy, Andrew ---------------- > Hello, > > The attached deletes floatformat_arm_ext from include/floatformat.h and libiberty/floatformat.c. As far as I know nothing uses it. GDB stopped using it some time ago. > > It has been replaced with the far more useful: > > const struct floatformat floatformat_arm_ext_big; > const struct floatformat floatformat_arm_ext_littlebyte_bigword; > > Any comments? If not I'll commit it in a few days. > Andrew > > > > Index: ./include/ChangeLog > 2002-02-23 Andrew Cagney > > * floatformat.h (floatformat_arm_ext): Delete declaration. > > Index: ./libiberty/ChangeLog > 2002-02-23 Andrew Cagney > > * floatformat.c (floatformat_arm_ext_big): Delete definition. > > Index: ./include/floatformat.h > =================================================================== > RCS file: /cvs/src/src/include/floatformat.h,v > retrieving revision 1.4 > diff -u -r1.4 floatformat.h > --- floatformat.h 2001/08/21 00:20:05 1.4 > +++ floatformat.h 2002/02/24 03:51:10 > @@ -96,7 +96,6 @@ > extern const struct floatformat floatformat_i960_ext; > extern const struct floatformat floatformat_m88110_ext; > extern const struct floatformat floatformat_m88110_harris_ext; > -extern const struct floatformat floatformat_arm_ext; /* deprecated. */ > extern const struct floatformat floatformat_arm_ext_big; > extern const struct floatformat floatformat_arm_ext_littlebyte_bigword; > /* IA-64 Floating Point register spilt into memory. */ > Index: ./libiberty/floatformat.c > =================================================================== > RCS file: /cvs/src/src/libiberty/floatformat.c,v > retrieving revision 1.5 > diff -u -r1.5 floatformat.c > --- floatformat.c 2001/08/21 00:20:07 1.5 > +++ floatformat.c 2002/02/24 03:51:16 > @@ -103,13 +103,6 @@ > floatformat_intbit_no, > "floatformat_m88110_ext_harris" > }; > -const struct floatformat floatformat_arm_ext = > -{ > - /* Bits 1 to 16 are unused. */ > - floatformat_big, 96, 0, 17, 15, 0x3fff, 0x7fff, 32, 64, > - floatformat_intbit_yes, > - "floatformat_arm_ext" > -}; > const struct floatformat floatformat_arm_ext_big = > { > /* Bits 1 to 16 are unused. */ >