Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [patch/rfc] Remove last IEEE_FLOAT use
@ 2002-01-15 22:23 Andrew Cagney
  2002-01-19 13:09 ` Andrew Cagney
  0 siblings, 1 reply; 4+ messages in thread
From: Andrew Cagney @ 2002-01-15 22:23 UTC (permalink / raw)
  To: gdb-patches

Hello,

The attached removes the last remaning use of IEEE_FLOAT.  I think it is 
ok.  The relevant block is:

-   /* FIXME: kettenis/2001-01-20: The check for IEEE_FLOAT is probably
-      still necessary since GDB by default assumes that the target uses
-      the IEEE 754 representation for its floats and doubles.  Of
-      course this is all crock and should be cleaned up.  */
-
-   if (len == TARGET_FLOAT_BIT / TARGET_CHAR_BIT && IEEE_FLOAT)
-     fmt = TARGET_FLOAT_FORMAT;
-   else if (len == TARGET_DOUBLE_BIT / TARGET_CHAR_BIT && IEEE_FLOAT)
-     fmt = TARGET_DOUBLE_FORMAT;
-   else if (len == TARGET_LONG_DOUBLE_BIT / TARGET_CHAR_BIT)
-     fmt = TARGET_LONG_DOUBLE_FORMAT;
-

Thinking hard about it.  I can't see how IEEE_FLOAT can make a real 
difference.  In all likelyhood both the host and target have IEEE float. 
  If one of them doesn't, the floatformat stuff should be kicking in and 
correctly handle any needed conversion.

Anyway, the above code block is replaced by a call to a new function 
floatformat_from_type().

Any comments?

Andrew


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2002-01-20 18:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-01-15 22:23 [patch/rfc] Remove last IEEE_FLOAT use Andrew Cagney
2002-01-19 13:09 ` Andrew Cagney
2002-01-20  0:31   ` Eli Zaretskii
2002-01-20 10:05   ` Andrew Cagney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox