From: Andrew Cagney <ac131313@cygnus.com>
To: gdb-patches@sources.redhat.com
Subject: [patch/rfc] Remove last IEEE_FLOAT use
Date: Tue, 15 Jan 2002 22:23:00 -0000 [thread overview]
Message-ID: <3C451C6C.5020508@cygnus.com> (raw)
Hello,
The attached removes the last remaning use of IEEE_FLOAT. I think it is
ok. The relevant block is:
- /* FIXME: kettenis/2001-01-20: The check for IEEE_FLOAT is probably
- still necessary since GDB by default assumes that the target uses
- the IEEE 754 representation for its floats and doubles. Of
- course this is all crock and should be cleaned up. */
-
- if (len == TARGET_FLOAT_BIT / TARGET_CHAR_BIT && IEEE_FLOAT)
- fmt = TARGET_FLOAT_FORMAT;
- else if (len == TARGET_DOUBLE_BIT / TARGET_CHAR_BIT && IEEE_FLOAT)
- fmt = TARGET_DOUBLE_FORMAT;
- else if (len == TARGET_LONG_DOUBLE_BIT / TARGET_CHAR_BIT)
- fmt = TARGET_LONG_DOUBLE_FORMAT;
-
Thinking hard about it. I can't see how IEEE_FLOAT can make a real
difference. In all likelyhood both the host and target have IEEE float.
If one of them doesn't, the floatformat stuff should be kicking in and
correctly handle any needed conversion.
Anyway, the above code block is replaced by a call to a new function
floatformat_from_type().
Any comments?
Andrew
next reply other threads:[~2002-01-16 6:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-15 22:23 Andrew Cagney [this message]
2002-01-19 13:09 ` Andrew Cagney
2002-01-20 0:31 ` Eli Zaretskii
2002-01-20 10:05 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C451C6C.5020508@cygnus.com \
--to=ac131313@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox