Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: matthew green <mrg@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch]: 2 more needed changes for sim-fpu.c & psim
Date: Fri, 14 Dec 2001 21:01:00 -0000	[thread overview]
Message-ID: <3C1AD903.4010401@cygnus.com> (raw)
In-Reply-To: <7.1008389753@cygnus.com>

>  I'm puzzled by some of the includes.  Well "defs.h" to be honest.   I 
>    know the PPC has a nasty hack so that it can access the GDB register 
>    names but I'm not sure that main.c - a standalone program - should 
>    include "defs.h".
> 
> main.c doesn't need defs.h, right.
>    
>    I think the error stuff should go to stderr.
> 
> hmm, i choose stdout because the "error" function a couple of pages
> above does the same...


Ah, ok then.


>    From memory, for the sim_call.c, the error stuff should go to the callback.
> 
> OK, i've done this..  how's this?
> 
> 
> 
> 	* main.c: Include "bfd.h", "callback.h" and "remote-sim.h".
> 	(sim_io_error): New function.
> 	* sim_calls.c: (sim_io_error): New function.
> 

Yes fine.

Thanks!
Andrew




      reply	other threads:[~2001-12-15  5:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-13 17:30 matthew green
2001-12-14 14:41 ` Andrew Cagney
2001-12-14 20:17   ` matthew green
2001-12-14 21:01     ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C1AD903.4010401@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mrg@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox