From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23814 invoked by alias); 15 Dec 2001 05:01:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23781 invoked from network); 15 Dec 2001 05:00:58 -0000 Received: from unknown (HELO localhost.cygnus.com) (24.114.42.213) by sources.redhat.com with SMTP; 15 Dec 2001 05:00:58 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.cygnus.com (Postfix) with ESMTP id AE3603E29; Sat, 15 Dec 2001 00:00:52 -0500 (EST) Message-ID: <3C1AD903.4010401@cygnus.com> Date: Fri, 14 Dec 2001 21:01:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.6) Gecko/20011207 X-Accept-Language: en-us MIME-Version: 1.0 To: matthew green Cc: gdb-patches@sources.redhat.com Subject: Re: [patch]: 2 more needed changes for sim-fpu.c & psim References: <7.1008389753@cygnus.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2001-12/txt/msg00395.txt.bz2 > I'm puzzled by some of the includes. Well "defs.h" to be honest. I > know the PPC has a nasty hack so that it can access the GDB register > names but I'm not sure that main.c - a standalone program - should > include "defs.h". > > main.c doesn't need defs.h, right. > > I think the error stuff should go to stderr. > > hmm, i choose stdout because the "error" function a couple of pages > above does the same... Ah, ok then. > From memory, for the sim_call.c, the error stuff should go to the callback. > > OK, i've done this.. how's this? > > > > * main.c: Include "bfd.h", "callback.h" and "remote-sim.h". > (sim_io_error): New function. > * sim_calls.c: (sim_io_error): New function. > Yes fine. Thanks! Andrew