Re: [patch]: 2 more needed changes for sim-fpu.c & psim

[Andrew Cagney <ac131313@cygnus.com>]

 
> + #include "defs.h"
> + #include "bfd.h"
> + #include "callback.h"
> + #include "remote-sim.h"


I'm puzzled by some of the includes.  Well "defs.h" to be honest.   I 
know the PPC has a nasty hack so that it can access the GDB register 
names but I'm not sure that main.c - a standalone program - should 
include "defs.h".


>   #ifdef HAVE_STDLIB_H
>   #include <stdlib.h>
> #endif
> *************** sim_io_flush_stdoutput(void)
> *** 220,225 ****
> --- 225,248 ----
>       error("sim_io_flush_stdoutput: invalid switch\n");
>       break;
>     }
> + }
> + 
> + void
> + sim_io_error (SIM_DESC sd, const char *msg, ...)
> + {
> +   va_list ap;
> +   va_start(ap, msg);
> +   vprintf(msg, ap);
> +   printf("\n");
> +   va_end(ap);


I think the error stuff should go to stderr.

 From memory, for the sim_call.c, the error stuff should go to the callback.

Andrew