From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-11319-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 23246 invoked by alias); 14 Dec 2001 22:41:18 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 23225 invoked from network); 14 Dec 2001 22:41:17 -0000
Received: from unknown (HELO localhost.cygnus.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 14 Dec 2001 22:41:17 -0000
Received: from cygnus.com (localhost [127.0.0.1])
	by localhost.cygnus.com (Postfix) with ESMTP
	id 817FC3D60; Fri, 14 Dec 2001 11:44:13 -0800 (PST)
Message-ID: <3C1A568D.3020300@cygnus.com>
Date: Fri, 14 Dec 2001 14:41:00 -0000
From: Andrew Cagney <ac131313@cygnus.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.6) Gecko/20011207
X-Accept-Language: en-us
MIME-Version: 1.0
To: matthew green <mrg@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch]: 2 more needed changes for sim-fpu.c & psim
References: <25809.1008293358@cygnus.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2001-12/txt/msg00386.txt.bz2

 
> + #include "defs.h"
> + #include "bfd.h"
> + #include "callback.h"
> + #include "remote-sim.h"


I'm puzzled by some of the includes.  Well "defs.h" to be honest.   I 
know the PPC has a nasty hack so that it can access the GDB register 
names but I'm not sure that main.c - a standalone program - should 
include "defs.h".


>   #ifdef HAVE_STDLIB_H
>   #include <stdlib.h>
> #endif
> *************** sim_io_flush_stdoutput(void)
> *** 220,225 ****
> --- 225,248 ----
>       error("sim_io_flush_stdoutput: invalid switch\n");
>       break;
>     }
> + }
> + 
> + void
> + sim_io_error (SIM_DESC sd, const char *msg, ...)
> + {
> +   va_list ap;
> +   va_start(ap, msg);
> +   vprintf(msg, ap);
> +   printf("\n");
> +   va_end(ap);


I think the error stuff should go to stderr.

 From memory, for the sim_call.c, the error stuff should go to the callback.

Andrew