From: Andrew Cagney <ac131313@cygnus.com>
To: gdb-patches <gdb-patches@sources.redhat.com>,
Corinna Vinschen <vinschen@cygnus.com>
Cc: Geoff Keating <geoffk@redhat.com>
Subject: Re: [RFA]: port to Sanyo XStormy16 CPU
Date: Thu, 13 Dec 2001 12:39:00 -0000 [thread overview]
Message-ID: <3C1911E2.70203@cygnus.com> (raw)
In-Reply-To: <20011213144437.A18705@cygbert.vinschen.de>
> Just the usual style things: can I suggest making macro's like
>> TYPE_IS_SCALAR functions; can you please put the .c files through
>> gdb/gdb_indent.sh so it matches GDB's indentation style.
>
>
> I've rearranged the macro TYPE_IS_SCALAR() to be a function called
> xstormy16_type_is_scalar and I ran gdb_indent.sh on xstormy16-tdep.c.
>
> Thanks for the approval, I've applied everything.
Corinna, thanks.
The next thing is to keep an eye on http://sources.redhat.com/gdb/ari/
to see if the files cause any regressions (any should show up tomorrow).
One thing that has already appeared is some file name problems in the
opcodes directory. They can be fixed by tweeking
gdb/config/djgpp/fnchange.lst (?) - the tweek is considered obvious.
enjoy,
Andrew
next prev parent reply other threads:[~2001-12-13 20:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-10 3:12 Corinna Vinschen
2001-12-11 15:45 ` Andrew Cagney
2001-12-13 5:45 ` Corinna Vinschen
2001-12-13 7:11 ` Corinna Vinschen
2001-12-13 12:39 ` Andrew Cagney [this message]
2001-12-14 1:28 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C1911E2.70203@cygnus.com \
--to=ac131313@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
--cc=geoffk@redhat.com \
--cc=vinschen@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox