From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches <gdb-patches@sources.redhat.com>
Subject: Re: [RFA]: port to Sanyo XStormy16 CPU
Date: Thu, 13 Dec 2001 05:45:00 -0000 [thread overview]
Message-ID: <20011213144437.A18705@cygbert.vinschen.de> (raw)
In-Reply-To: <3C1693C3.9000106@cygnus.com>; from ac131313@cygnus.com on Tue, Dec 11, 2001 at 03:16:19PM -0800
On Tue, Dec 11, 2001 at 03:16:19PM -0800, Andrew Cagney wrote:
> > Corinna
> >
> > gdb ChangeLog:
> >
> > 2001-12-10 Corinna Vinschen <vinschen@redhat.com>
> >
> > * Makefile.in: Add support for xstormy16.
> > * configure.tgt: Ditto.
> > * xstormy16-tdep.c: New file.
> > * config/xstormy16/xstormy16.mt: New file.
> >
> > gdb/testsuite ChangeLog:
>
>
> Yes. Your code is fine. The comments are very much appreciated.
>
> Just the usual style things: can I suggest making macro's like
> TYPE_IS_SCALAR functions; can you please put the .c files through
> gdb/gdb_indent.sh so it matches GDB's indentation style.
I've rearranged the macro TYPE_IS_SCALAR() to be a function called
xstormy16_type_is_scalar and I ran gdb_indent.sh on xstormy16-tdep.c.
Thanks for the approval, I've applied everything.
Corinna
--
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:vinschen@redhat.com
next prev parent reply other threads:[~2001-12-13 13:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-10 3:12 Corinna Vinschen
2001-12-11 15:45 ` Andrew Cagney
2001-12-13 5:45 ` Corinna Vinschen [this message]
2001-12-13 7:11 ` Corinna Vinschen
2001-12-13 12:39 ` Andrew Cagney
2001-12-14 1:28 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011213144437.A18705@cygbert.vinschen.de \
--to=vinschen@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox