From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32579 invoked by alias); 13 Dec 2001 13:45:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32423 invoked from network); 13 Dec 2001 13:45:12 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 13 Dec 2001 13:45:12 -0000 Received: from cygbert.vinschen.de (cse.cygnus.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id FAA16895 for ; Thu, 13 Dec 2001 05:45:08 -0800 (PST) Received: (from corinna@localhost) by cygbert.vinschen.de (8.9.3/8.9.3/Linux sendmail 8.9.3) id OAA18722 for gdb-patches@sources.redhat.com; Thu, 13 Dec 2001 14:44:37 +0100 Date: Thu, 13 Dec 2001 05:45:00 -0000 From: Corinna Vinschen To: gdb-patches Subject: Re: [RFA]: port to Sanyo XStormy16 CPU Message-ID: <20011213144437.A18705@cygbert.vinschen.de> Reply-To: gdb-patches Mail-Followup-To: gdb-patches References: <20011210121151.H740@cygbert.vinschen.de> <3C1693C3.9000106@cygnus.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <3C1693C3.9000106@cygnus.com>; from ac131313@cygnus.com on Tue, Dec 11, 2001 at 03:16:19PM -0800 X-SW-Source: 2001-12/txt/msg00342.txt.bz2 On Tue, Dec 11, 2001 at 03:16:19PM -0800, Andrew Cagney wrote: > > Corinna > > > > gdb ChangeLog: > > > > 2001-12-10 Corinna Vinschen > > > > * Makefile.in: Add support for xstormy16. > > * configure.tgt: Ditto. > > * xstormy16-tdep.c: New file. > > * config/xstormy16/xstormy16.mt: New file. > > > > gdb/testsuite ChangeLog: > > > Yes. Your code is fine. The comments are very much appreciated. > > Just the usual style things: can I suggest making macro's like > TYPE_IS_SCALAR functions; can you please put the .c files through > gdb/gdb_indent.sh so it matches GDB's indentation style. I've rearranged the macro TYPE_IS_SCALAR() to be a function called xstormy16_type_is_scalar and I ran gdb_indent.sh on xstormy16-tdep.c. Thanks for the approval, I've applied everything. Corinna -- Corinna Vinschen Cygwin Developer Red Hat, Inc. mailto:vinschen@redhat.com