From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19359 invoked by alias); 13 Dec 2001 20:39:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19329 invoked from network); 13 Dec 2001 20:39:03 -0000 Received: from unknown (HELO localhost.cygnus.com) (205.180.231.71) by sources.redhat.com with SMTP; 13 Dec 2001 20:39:03 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.cygnus.com (Postfix) with ESMTP id 35C7F3D60; Thu, 13 Dec 2001 12:38:58 -0800 (PST) Message-ID: <3C1911E2.70203@cygnus.com> Date: Thu, 13 Dec 2001 12:39:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.6) Gecko/20011207 X-Accept-Language: en-us MIME-Version: 1.0 To: gdb-patches , Corinna Vinschen Cc: Geoff Keating Subject: Re: [RFA]: port to Sanyo XStormy16 CPU References: <20011210121151.H740@cygbert.vinschen.de> <3C1693C3.9000106@cygnus.com> <20011213144437.A18705@cygbert.vinschen.de> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2001-12/txt/msg00360.txt.bz2 > Just the usual style things: can I suggest making macro's like >> TYPE_IS_SCALAR functions; can you please put the .c files through >> gdb/gdb_indent.sh so it matches GDB's indentation style. > > > I've rearranged the macro TYPE_IS_SCALAR() to be a function called > xstormy16_type_is_scalar and I ran gdb_indent.sh on xstormy16-tdep.c. > > Thanks for the approval, I've applied everything. Corinna, thanks. The next thing is to keep an eye on http://sources.redhat.com/gdb/ari/ to see if the files cause any regressions (any should show up tomorrow). One thing that has already appeared is some file name problems in the opcodes directory. They can be fixed by tweeking gdb/config/djgpp/fnchange.lst (?) - the tweek is considered obvious. enjoy, Andrew