Re: [RFA] volatile.exp fix-ups

Re: [RFA] volatile.exp fix-ups

[Fernando Nasser]

Michael Snyder wrote:
> 
> This extends the work that Corinna and I did on constvars.exp
> into volatile.exp (allowing the test to proceed if compiled
> with gcc and dwarf-2).
> 
> Tested on Linux native with both stabs (xfail) and dwarf-2 (pass)
> 

Sure thing.

Thanks Michael and Corinna.

Fernando



>   ------------------------------------------------------------------------
> 2001-09-27  Michael Snyder  <msnyder@redhat.com>
> 
>         * gdb.base/volatile.exp (local_compiler_xfail_check): New
>         proc; use new service proc test_debug_format.
>         Replace all other "gcc_compiled" tests with this test.
> 
> Index: gdb.base/volatile.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/volatile.exp,v
> retrieving revision 1.2
> diff -c -3 -p -r1.2 volatile.exp
> *** volatile.exp        2001/03/06 08:21:51     1.2
> --- volatile.exp        2001/09/27 21:07:48
> *************** if ![runto_main] then {
> *** 79,84 ****
> --- 79,97 ----
>       continue
>   }
> 
> + get_debug_format
> +
> + proc local_compiler_xfail_check { } {
> +     global gcc_compiled;
> +
> +     if {$gcc_compiled} then {
> +       if { ![test_debug_format "HP"] \
> +               && ![test_debug_format "DWARF 2"] } then {
> +           setup_xfail "*-*-*"
> +       }
> +     }
> + }
> +
>   send_gdb "break marker1\n" ; gdb_expect -re ".*$gdb_prompt $"
> 
>       send_gdb "cont\n"
> *************** send_gdb "break marker1\n" ; gdb_expect
> *** 105,244 ****
>   # As of Feb 1999, GCC does not issue info about volatility of vars, so
>   # these tests are all expected to fail if GCC is the compiler. -sts
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vox" "type = volatile char.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype victuals" "type = volatile unsigned char.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vixen" "type = volatile short.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> ! gdb_test "ptype vitriol" "type = volatile unsigned short.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vellum" "type = volatile long.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> ! gdb_test "ptype valve" "type = volatile unsigned long.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vacuity" "type = volatile float.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vertigo" "type = volatile double.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vampire" "type = volatile char \\*.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype viper" "type = volatile unsigned char \\*.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> ! gdb_test "ptype vigour" "type = volatile short \\*.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> ! gdb_test "ptype vapour" "type = volatile unsigned short \\*.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> ! gdb_test "ptype ventricle" "type = volatile long \\*.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> ! gdb_test "ptype vigintillion" "type = volatile unsigned long \\*.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vocation" "type = volatile float \\*.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype veracity" "type = volatile double \\*.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vapidity" "type = volatile char \\* volatile.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype velocity" "type = volatile unsigned char \\* volatile.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> ! gdb_test "ptype veneer" "type = volatile short \\* volatile.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> ! gdb_test "ptype video" "type = volatile unsigned short \\* volatile.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> ! gdb_test "ptype vacuum" "type = volatile long \\* volatile.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> ! gdb_test "ptype veniality" "type = volatile unsigned long \\* volatile.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vitality" "type = volatile float \\* volatile.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype voracity" "type = volatile double \\* volatile.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype victor" "type = const volatile char.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vicar" "type = const volatile unsigned char.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype victory" "type = const volatile char \\*.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vicarage" "type = const volatile unsigned char \\*.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vein" "type = volatile char \\* const.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vogue" "type = volatile unsigned char \\* const.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype cavern" "type = const volatile char \\* const.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype coverlet" "type = const volatile unsigned char \\* const.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype caveat" "type = const char \\* volatile.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype covenant" "type = const unsigned char \\* volatile.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vizier" "type = const volatile char \\* volatile.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vanadium" "type = const volatile unsigned char \\* volatile.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vane" "type = char \\* const volatile.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype veldt" "type = unsigned char \\* const volatile.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype cove" "type = const char \\* const volatile.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype cavity" "type = const unsigned char \\* const volatile.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vagus" "type = volatile char \\* const volatile.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vagrancy" "type = volatile unsigned char \\* const volatile.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vagary" "type = const volatile char \\* const volatile.*"
> 
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   gdb_test "ptype vendor" "type = const volatile unsigned char \\* const volatile.*"
> 
>   # test function parameters
> ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
>   send_gdb "ptype qux2\n"
>   gdb_expect {
>       -re "type = int \\(volatile unsigned char, const volatile int, volatile short, volatile long \\*, float \\* volatile, const volatile signed char \\* const volatile\\).*$gdb_prompt $" {
> --- 118,257 ----
>   # As of Feb 1999, GCC does not issue info about volatility of vars, so
>   # these tests are all expected to fail if GCC is the compiler. -sts
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vox" "type = volatile char.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype victuals" "type = volatile unsigned char.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vixen" "type = volatile short.*"
> 
> ! local_compiler_xfail_check
> ! gdb_test "ptype vitriol" "type = volatile (unsigned short|short unsigned)( int)?.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vellum" "type = volatile long.*"
> 
> ! local_compiler_xfail_check
> ! gdb_test "ptype valve" "type = volatile (unsigned long|long unsigned)( int)?.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vacuity" "type = volatile float.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vertigo" "type = volatile double.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vampire" "type = volatile char \\*.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype viper" "type = volatile unsigned char \\*.*"
> 
> ! local_compiler_xfail_check
> ! gdb_test "ptype vigour" "type = volatile short( int)? \\*.*"
> 
> ! local_compiler_xfail_check
> ! gdb_test "ptype vapour" "type = volatile (unsigned short|short unsigned)( int)? \\*.*"
> 
> ! local_compiler_xfail_check
> ! gdb_test "ptype ventricle" "type = volatile long( int)? \\*.*"
> 
> ! local_compiler_xfail_check
> ! gdb_test "ptype vigintillion" "type = volatile (unsigned long|long unsigned)( int)? \\*.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vocation" "type = volatile float \\*.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype veracity" "type = volatile double \\*.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vapidity" "type = volatile char \\* volatile.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype velocity" "type = volatile unsigned char \\* volatile.*"
> 
> ! local_compiler_xfail_check
> ! gdb_test "ptype veneer" "type = volatile short( int)? \\* volatile.*"
> 
> ! local_compiler_xfail_check
> ! gdb_test "ptype video" "type = volatile (unsigned short|short unsigned)( int) \\* volatile.*"
> 
> ! local_compiler_xfail_check
> ! gdb_test "ptype vacuum" "type = volatile long( int)? \\* volatile.*"
> 
> ! local_compiler_xfail_check
> ! gdb_test "ptype veniality" "type = volatile (unsigned long|long unsigned)( int)? \\* volatile.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vitality" "type = volatile float \\* volatile.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype voracity" "type = volatile double \\* volatile.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype victor" "type = const volatile char.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vicar" "type = const volatile unsigned char.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype victory" "type = const volatile char \\*.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vicarage" "type = const volatile unsigned char \\*.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vein" "type = volatile char \\* const.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vogue" "type = volatile unsigned char \\* const.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype cavern" "type = const volatile char \\* const.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype coverlet" "type = const volatile unsigned char \\* const.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype caveat" "type = const char \\* volatile.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype covenant" "type = const unsigned char \\* volatile.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vizier" "type = const volatile char \\* volatile.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vanadium" "type = const volatile unsigned char \\* volatile.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vane" "type = char \\* const volatile.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype veldt" "type = unsigned char \\* const volatile.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype cove" "type = const char \\* const volatile.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype cavity" "type = const unsigned char \\* const volatile.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vagus" "type = volatile char \\* const volatile.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vagrancy" "type = volatile unsigned char \\* const volatile.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vagary" "type = const volatile char \\* const volatile.*"
> 
> ! local_compiler_xfail_check
>   gdb_test "ptype vendor" "type = const volatile unsigned char \\* const volatile.*"
> 
>   # test function parameters
> ! local_compiler_xfail_check
>   send_gdb "ptype qux2\n"
>   gdb_expect {
>       -re "type = int \\(volatile unsigned char, const volatile int, volatile short, volatile long \\*, float \\* volatile, const volatile signed char \\* const volatile\\).*$gdb_prompt $" {

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9

Re: [RFA] volatile.exp fix-ups

[Michael Snyder]

Fernando Nasser wrote:
> 
> Michael Snyder wrote:
> >
> > This extends the work that Corinna and I did on constvars.exp
> > into volatile.exp (allowing the test to proceed if compiled
> > with gcc and dwarf-2).
> >
> > Tested on Linux native with both stabs (xfail) and dwarf-2 (pass)
> >
> 
> Sure thing.
> 
> Thanks Michael and Corinna.
> 
> Fernando

Nice collaboration.  I should metion that Jim Blandy and Fernando
both gave valuable feedback off-list.

Committed.

> 
> >   ------------------------------------------------------------------------
> > 2001-09-27  Michael Snyder  <msnyder@redhat.com>
> >
> >         * gdb.base/volatile.exp (local_compiler_xfail_check): New
> >         proc; use new service proc test_debug_format.
> >         Replace all other "gcc_compiled" tests with this test.
> >
> > Index: gdb.base/volatile.exp
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/volatile.exp,v
> > retrieving revision 1.2
> > diff -c -3 -p -r1.2 volatile.exp
> > *** volatile.exp        2001/03/06 08:21:51     1.2
> > --- volatile.exp        2001/09/27 21:07:48
> > *************** if ![runto_main] then {
> > *** 79,84 ****
> > --- 79,97 ----
> >       continue
> >   }
> >
> > + get_debug_format
> > +
> > + proc local_compiler_xfail_check { } {
> > +     global gcc_compiled;
> > +
> > +     if {$gcc_compiled} then {
> > +       if { ![test_debug_format "HP"] \
> > +               && ![test_debug_format "DWARF 2"] } then {
> > +           setup_xfail "*-*-*"
> > +       }
> > +     }
> > + }
> > +
> >   send_gdb "break marker1\n" ; gdb_expect -re ".*$gdb_prompt $"
> >
> >       send_gdb "cont\n"
> > *************** send_gdb "break marker1\n" ; gdb_expect
> > *** 105,244 ****
> >   # As of Feb 1999, GCC does not issue info about volatility of vars, so
> >   # these tests are all expected to fail if GCC is the compiler. -sts
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vox" "type = volatile char.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype victuals" "type = volatile unsigned char.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vixen" "type = volatile short.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> > ! gdb_test "ptype vitriol" "type = volatile unsigned short.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vellum" "type = volatile long.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> > ! gdb_test "ptype valve" "type = volatile unsigned long.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vacuity" "type = volatile float.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vertigo" "type = volatile double.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vampire" "type = volatile char \\*.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype viper" "type = volatile unsigned char \\*.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> > ! gdb_test "ptype vigour" "type = volatile short \\*.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> > ! gdb_test "ptype vapour" "type = volatile unsigned short \\*.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> > ! gdb_test "ptype ventricle" "type = volatile long \\*.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> > ! gdb_test "ptype vigintillion" "type = volatile unsigned long \\*.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vocation" "type = volatile float \\*.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype veracity" "type = volatile double \\*.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vapidity" "type = volatile char \\* volatile.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype velocity" "type = volatile unsigned char \\* volatile.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> > ! gdb_test "ptype veneer" "type = volatile short \\* volatile.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> > ! gdb_test "ptype video" "type = volatile unsigned short \\* volatile.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> > ! gdb_test "ptype vacuum" "type = volatile long \\* volatile.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> > ! gdb_test "ptype veniality" "type = volatile unsigned long \\* volatile.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vitality" "type = volatile float \\* volatile.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype voracity" "type = volatile double \\* volatile.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype victor" "type = const volatile char.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vicar" "type = const volatile unsigned char.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype victory" "type = const volatile char \\*.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vicarage" "type = const volatile unsigned char \\*.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vein" "type = volatile char \\* const.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vogue" "type = volatile unsigned char \\* const.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype cavern" "type = const volatile char \\* const.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype coverlet" "type = const volatile unsigned char \\* const.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype caveat" "type = const char \\* volatile.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype covenant" "type = const unsigned char \\* volatile.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vizier" "type = const volatile char \\* volatile.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vanadium" "type = const volatile unsigned char \\* volatile.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vane" "type = char \\* const volatile.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype veldt" "type = unsigned char \\* const volatile.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype cove" "type = const char \\* const volatile.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype cavity" "type = const unsigned char \\* const volatile.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vagus" "type = volatile char \\* const volatile.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vagrancy" "type = volatile unsigned char \\* const volatile.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vagary" "type = const volatile char \\* const volatile.*"
> >
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   gdb_test "ptype vendor" "type = const volatile unsigned char \\* const volatile.*"
> >
> >   # test function parameters
> > ! if {$gcc_compiled} then { setup_xfail "*-*-*" }
> >   send_gdb "ptype qux2\n"
> >   gdb_expect {
> >       -re "type = int \\(volatile unsigned char, const volatile int, volatile short, volatile long \\*, float \\* volatile, const volatile signed char \\* const volatile\\).*$gdb_prompt $" {
> > --- 118,257 ----
> >   # As of Feb 1999, GCC does not issue info about volatility of vars, so
> >   # these tests are all expected to fail if GCC is the compiler. -sts
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vox" "type = volatile char.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype victuals" "type = volatile unsigned char.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vixen" "type = volatile short.*"
> >
> > ! local_compiler_xfail_check
> > ! gdb_test "ptype vitriol" "type = volatile (unsigned short|short unsigned)( int)?.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vellum" "type = volatile long.*"
> >
> > ! local_compiler_xfail_check
> > ! gdb_test "ptype valve" "type = volatile (unsigned long|long unsigned)( int)?.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vacuity" "type = volatile float.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vertigo" "type = volatile double.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vampire" "type = volatile char \\*.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype viper" "type = volatile unsigned char \\*.*"
> >
> > ! local_compiler_xfail_check
> > ! gdb_test "ptype vigour" "type = volatile short( int)? \\*.*"
> >
> > ! local_compiler_xfail_check
> > ! gdb_test "ptype vapour" "type = volatile (unsigned short|short unsigned)( int)? \\*.*"
> >
> > ! local_compiler_xfail_check
> > ! gdb_test "ptype ventricle" "type = volatile long( int)? \\*.*"
> >
> > ! local_compiler_xfail_check
> > ! gdb_test "ptype vigintillion" "type = volatile (unsigned long|long unsigned)( int)? \\*.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vocation" "type = volatile float \\*.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype veracity" "type = volatile double \\*.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vapidity" "type = volatile char \\* volatile.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype velocity" "type = volatile unsigned char \\* volatile.*"
> >
> > ! local_compiler_xfail_check
> > ! gdb_test "ptype veneer" "type = volatile short( int)? \\* volatile.*"
> >
> > ! local_compiler_xfail_check
> > ! gdb_test "ptype video" "type = volatile (unsigned short|short unsigned)( int) \\* volatile.*"
> >
> > ! local_compiler_xfail_check
> > ! gdb_test "ptype vacuum" "type = volatile long( int)? \\* volatile.*"
> >
> > ! local_compiler_xfail_check
> > ! gdb_test "ptype veniality" "type = volatile (unsigned long|long unsigned)( int)? \\* volatile.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vitality" "type = volatile float \\* volatile.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype voracity" "type = volatile double \\* volatile.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype victor" "type = const volatile char.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vicar" "type = const volatile unsigned char.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype victory" "type = const volatile char \\*.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vicarage" "type = const volatile unsigned char \\*.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vein" "type = volatile char \\* const.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vogue" "type = volatile unsigned char \\* const.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype cavern" "type = const volatile char \\* const.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype coverlet" "type = const volatile unsigned char \\* const.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype caveat" "type = const char \\* volatile.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype covenant" "type = const unsigned char \\* volatile.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vizier" "type = const volatile char \\* volatile.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vanadium" "type = const volatile unsigned char \\* volatile.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vane" "type = char \\* const volatile.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype veldt" "type = unsigned char \\* const volatile.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype cove" "type = const char \\* const volatile.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype cavity" "type = const unsigned char \\* const volatile.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vagus" "type = volatile char \\* const volatile.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vagrancy" "type = volatile unsigned char \\* const volatile.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vagary" "type = const volatile char \\* const volatile.*"
> >
> > ! local_compiler_xfail_check
> >   gdb_test "ptype vendor" "type = const volatile unsigned char \\* const volatile.*"
> >
> >   # test function parameters
> > ! local_compiler_xfail_check
> >   send_gdb "ptype qux2\n"
> >   gdb_expect {
> >       -re "type = int \\(volatile unsigned char, const volatile int, volatile short, volatile long \\*, float \\* volatile, const volatile signed char \\* const volatile\\).*$gdb_prompt $" {
> 
> --
> Fernando Nasser
> Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
> 2323 Yonge Street, Suite #300
> Toronto, Ontario   M4P 2C9

Re: [RFA] volatile.exp fix-ups

[Corinna Vinschen]

On Thu, Sep 27, 2001 at 02:38:10PM -0700, Michael Snyder wrote:
> Fernando Nasser wrote:
> > 
> > Michael Snyder wrote:
> > >
> > > This extends the work that Corinna and I did on constvars.exp
> > > into volatile.exp (allowing the test to proceed if compiled
> > > with gcc and dwarf-2).
> > >
> > > Tested on Linux native with both stabs (xfail) and dwarf-2 (pass)
> > >
> > 
> > Sure thing.
> > 
> > Thanks Michael and Corinna.
> > 
> > Fernando
> 
> Nice collaboration.  I should metion that Jim Blandy and Fernando
> both gave valuable feedback off-list.

I have just commited the following patch to gdb.base/volatile.exp
as `obvious' patch.  It just accepts additional `int' keywords in the
output of the qux2 test.

2001-09-28  Corinna Vinschen  <vinschen@redhat.com>

        * gdb.base/volatile.exp (local_compiler_xfail_check): Change qux2
        check to allow additional `int'.

Index: volatile.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/volatile.exp,v
retrieving revision 1.3
diff -u -p -r1.3 volatile.exp
--- volatile.exp        2001/09/27 21:35:56     1.3
+++ volatile.exp        2001/09/28 11:39:31
@@ -254,7 +254,7 @@ gdb_test "ptype vendor" "type = const vo
 local_compiler_xfail_check
 send_gdb "ptype qux2\n"
 gdb_expect {
-    -re "type = int \\(volatile unsigned char, const volatile int, volatile sho
rt, volatile long \\*, float \\* volatile, const volatile signed char \\* const 
volatile\\).*$gdb_prompt $" {
+    -re "type = int \\(volatile unsigned char, const volatile int, volatile sho
rt( int)?, volatile long( int)? \\*, float \\* volatile, const volatile signed c
har \\* const volatile\\).*$gdb_prompt $" {
         pass "ptype qux2"
     }
     -re ".*$gdb_prompt $" { fail "ptype qux2" }

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:vinschen@redhat.com

Re: [RFA] volatile.exp fix-ups

[Michael Snyder]

Corinna Vinschen wrote:
> 
> On Thu, Sep 27, 2001 at 02:38:10PM -0700, Michael Snyder wrote:
> > Fernando Nasser wrote:
> > >
> > > Michael Snyder wrote:
> > > >
> > > > This extends the work that Corinna and I did on constvars.exp
> > > > into volatile.exp (allowing the test to proceed if compiled
> > > > with gcc and dwarf-2).
> > > >
> > > > Tested on Linux native with both stabs (xfail) and dwarf-2 (pass)
> > > >
> > >
> > > Sure thing.
> > >
> > > Thanks Michael and Corinna.
> > >
> > > Fernando
> >
> > Nice collaboration.  I should metion that Jim Blandy and Fernando
> > both gave valuable feedback off-list.
> 
> I have just commited the following patch to gdb.base/volatile.exp
> as `obvious' patch.  It just accepts additional `int' keywords in the
> output of the qux2 test.

Thanks, I missed that.