From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] volatile.exp fix-ups Date: Fri, 28 Sep 2001 04:44:00 -0000 Message-id: <20010928134410.S21192@cygbert.vinschen.de> References: <3BB395AC.6CC343C5@cygnus.com> <3BB39698.BD9361A8@redhat.com> <3BB39C42.A0A311BE@cygnus.com> X-SW-Source: 2001-09/msg00413.html On Thu, Sep 27, 2001 at 02:38:10PM -0700, Michael Snyder wrote: > Fernando Nasser wrote: > > > > Michael Snyder wrote: > > > > > > This extends the work that Corinna and I did on constvars.exp > > > into volatile.exp (allowing the test to proceed if compiled > > > with gcc and dwarf-2). > > > > > > Tested on Linux native with both stabs (xfail) and dwarf-2 (pass) > > > > > > > Sure thing. > > > > Thanks Michael and Corinna. > > > > Fernando > > Nice collaboration. I should metion that Jim Blandy and Fernando > both gave valuable feedback off-list. I have just commited the following patch to gdb.base/volatile.exp as `obvious' patch. It just accepts additional `int' keywords in the output of the qux2 test. 2001-09-28 Corinna Vinschen * gdb.base/volatile.exp (local_compiler_xfail_check): Change qux2 check to allow additional `int'. Index: volatile.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/volatile.exp,v retrieving revision 1.3 diff -u -p -r1.3 volatile.exp --- volatile.exp 2001/09/27 21:35:56 1.3 +++ volatile.exp 2001/09/28 11:39:31 @@ -254,7 +254,7 @@ gdb_test "ptype vendor" "type = const vo local_compiler_xfail_check send_gdb "ptype qux2\n" gdb_expect { - -re "type = int \\(volatile unsigned char, const volatile int, volatile sho rt, volatile long \\*, float \\* volatile, const volatile signed char \\* const volatile\\).*$gdb_prompt $" { + -re "type = int \\(volatile unsigned char, const volatile int, volatile sho rt( int)?, volatile long( int)? \\*, float \\* volatile, const volatile signed c har \\* const volatile\\).*$gdb_prompt $" { pass "ptype qux2" } -re ".*$gdb_prompt $" { fail "ptype qux2" } -- Corinna Vinschen Cygwin Developer Red Hat, Inc. mailto:vinschen@redhat.com