From: Fernando Nasser <fnasser@redhat.com>
To: Michael Snyder <msnyder@cygnus.com>
Cc: Kevin Buettner <kevinb@cygnus.com>, Jim Blandy <jimb@cygnus.com>,
gdb-patches@sources.redhat.com, Keith Seitz <keiths@cygnus.com>
Subject: Re: [PATCH RFA] breakpoint.c: Pass breakpoint type to set_raw_breakpoint()
Date: Fri, 11 May 2001 10:29:00 -0000 [thread overview]
Message-ID: <3AFC2113.5A85D353@redhat.com> (raw)
In-Reply-To: <3AFC1ED7.9458AEE1@cygnus.com>
Michael Snyder wrote:
>
> Kevin, I like it, but I noticed that set_raw_breakpoint is not static.
> It was made extern in 1998, and is used by gdbtk-cmds.c.
>
> Can you check to see if that call needs a bp_type argument, and if that
> call can't be eliminated, maybe you should add a prototype to breakpoint.h.
>
I believe it can be made static now. I don't think anyone should be
using it outside breakpoint.c.
Keith, does your new gdbtk-bp.c uses this function?
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9
next prev parent reply other threads:[~2001-05-11 10:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-11 0:51 Kevin Buettner
2001-05-11 8:39 ` Fernando Nasser
2001-05-11 12:04 ` Kevin Buettner
2001-05-11 10:16 ` Jim Blandy
2001-05-11 10:18 ` Michael Snyder
2001-05-11 10:29 ` Fernando Nasser [this message]
2001-05-11 11:35 ` Kevin Buettner
2001-05-11 16:52 ` Keith Seitz
2001-05-11 13:10 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AFC2113.5A85D353@redhat.com \
--to=fnasser@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@cygnus.com \
--cc=keiths@cygnus.com \
--cc=kevinb@cygnus.com \
--cc=msnyder@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox