From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fernando Nasser To: Michael Snyder Cc: Kevin Buettner , Jim Blandy , gdb-patches@sources.redhat.com, Keith Seitz Subject: Re: [PATCH RFA] breakpoint.c: Pass breakpoint type to set_raw_breakpoint() Date: Fri, 11 May 2001 10:29:00 -0000 Message-id: <3AFC2113.5A85D353@redhat.com> References: <1010511075057.ZM27226@ocotillo.lan> <3AFC1ED7.9458AEE1@cygnus.com> X-SW-Source: 2001-05/msg00225.html Michael Snyder wrote: > > Kevin, I like it, but I noticed that set_raw_breakpoint is not static. > It was made extern in 1998, and is used by gdbtk-cmds.c. > > Can you check to see if that call needs a bp_type argument, and if that > call can't be eliminated, maybe you should add a prototype to breakpoint.h. > I believe it can be made static now. I don't think anyone should be using it outside breakpoint.c. Keith, does your new gdbtk-bp.c uses this function? -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9