From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 1/2][master+8.3] (Windows) fix thr != nullptr assert failure in delete_thread_1
Date: Thu, 18 Apr 2019 15:04:00 -0000 [thread overview]
Message-ID: <395ad477-eaaf-8df2-a701-e79859b85fb1@redhat.com> (raw)
In-Reply-To: <f6f937cb-2e0e-d602-2015-75467bd181e8@redhat.com>
On 4/18/19 3:52 PM, Pedro Alves wrote:
>> @@ -1637,11 +1629,11 @@ get_windows_debug_event (struct target_ops *ops,
>> else if (saw_create == 1)
>> {
>> windows_delete_thread (ptid_t (current_event.dwProcessId, 0,
>> - main_thread_id),
>> - 0, true /* main_thread_p */);
>> + current_event.dwThreadId),
>> + 0);
>> ourstatus->kind = TARGET_WAITKIND_EXITED;
>> ourstatus->value.integer = current_event.u.ExitProcess.dwExitCode;
>> - thread_id = main_thread_id;
>> + thread_id = current_event.dwThreadId;
>> }
>> break;
>
> This looks right.
I forgot to add: reading this made me wonder -- what about gdbserver?
I looked, and while gdbserver/win32-low.c had an equivalent of main_thread_id,
it doesn't use it for EXIT_PROCESS_DEBUG_EVENT either.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2019-04-18 15:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 22:33 Windows native GDB event handling enhancement Joel Brobecker
2019-04-16 22:33 ` [RFA 2/2][master only] gdb/windows-nat.c: Get rid of main_thread_id global Joel Brobecker
[not found] ` <83imvcg0ud.fsf@gnu.org>
2019-04-17 17:38 ` Joel Brobecker
2019-04-17 18:29 ` Eli Zaretskii
2019-04-17 22:17 ` Joel Brobecker
2019-04-18 12:52 ` Eli Zaretskii
2019-04-18 14:54 ` Joel Brobecker
2019-04-18 16:27 ` Pedro Alves
2019-04-19 20:43 ` Joel Brobecker
2019-04-22 14:24 ` Pedro Alves
2019-04-22 15:20 ` André Pönitz
2019-04-22 17:29 ` Pedro Alves
2019-04-22 21:42 ` André Pönitz
2019-04-23 5:54 ` Eli Zaretskii
2019-04-24 20:10 ` André Pönitz
2019-04-25 5:39 ` Eli Zaretskii
2019-04-23 11:42 ` Pedro Alves
2019-04-16 22:33 ` [RFA 1/2][master+8.3] (Windows) fix thr != nullptr assert failure in delete_thread_1 Joel Brobecker
2019-04-18 14:52 ` Pedro Alves
2019-04-18 15:04 ` Pedro Alves [this message]
2019-04-28 16:58 ` [v2] Windows native GDB event handling enhancement Joel Brobecker
2019-04-28 16:58 ` [RFA v2 1/2][master+8.3] (Windows) fix thr != nullptr assert failure in delete_thread_1 Joel Brobecker
2019-04-28 16:58 ` [RFA v2 2/2][master only] gdb/windows-nat.c: Get rid of main_thread_id global Joel Brobecker
2019-04-30 13:00 ` [v2] Windows native GDB event handling enhancement Pedro Alves
2019-04-30 21:04 ` pushed(master+8.3): " Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=395ad477-eaaf-8df2-a701-e79859b85fb1@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox