From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: [v2] Windows native GDB event handling enhancement
Date: Sun, 28 Apr 2019 16:58:00 -0000 [thread overview]
Message-ID: <1556470691-146942-1-git-send-email-brobecker@adacore.com> (raw)
In-Reply-To: <1555453982-77808-1-git-send-email-brobecker@adacore.com>
Hello,
This is v2 of the patch series, which now consists of 2 patches:
* [RFA v2 1/2] (Windows) fix thr != nullptr assert failure in
Compared to v1, it has been reduced to the essence of the fix,
which is to avoid using main_thread_id during the exit-process
event; and that's it.
* [RFA v2 2/2] gdb/windows-nat.c: Get rid of main_thread_id global
That one shold be unchanged.
The part that re-instated the thread notifications for the main thread
(at create-process event) and for the last thread (at exit-process
event) has been excised from v1 of patch #1. I think this is the best
compromise based on the discussions so far.
I will personally miss the silenced notifications, but for those
like me, we can enable the windows event debug logs.
The reason why I kept the patches split in two is so that I can apply
patch #1 on the gdb-8.3 branch as well. Patch #2 has been behaving
well as far as AdaCore nightly testing is concerned, but it's only
been a few weeks since we implemented it, and I think it deserves
more time in master before being in a release.
The patches were tested on both 32bit and 64bit native windows,
using AdaCore testsuite. OK to push?
Thanks,
--
Joel
next prev parent reply other threads:[~2019-04-28 16:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 22:33 Joel Brobecker
2019-04-16 22:33 ` [RFA 1/2][master+8.3] (Windows) fix thr != nullptr assert failure in delete_thread_1 Joel Brobecker
2019-04-18 14:52 ` Pedro Alves
2019-04-18 15:04 ` Pedro Alves
2019-04-16 22:33 ` [RFA 2/2][master only] gdb/windows-nat.c: Get rid of main_thread_id global Joel Brobecker
[not found] ` <83imvcg0ud.fsf@gnu.org>
2019-04-17 17:38 ` Joel Brobecker
2019-04-17 18:29 ` Eli Zaretskii
2019-04-17 22:17 ` Joel Brobecker
2019-04-18 12:52 ` Eli Zaretskii
2019-04-18 14:54 ` Joel Brobecker
2019-04-18 16:27 ` Pedro Alves
2019-04-19 20:43 ` Joel Brobecker
2019-04-22 14:24 ` Pedro Alves
2019-04-22 15:20 ` André Pönitz
2019-04-22 17:29 ` Pedro Alves
2019-04-22 21:42 ` André Pönitz
2019-04-23 5:54 ` Eli Zaretskii
2019-04-24 20:10 ` André Pönitz
2019-04-25 5:39 ` Eli Zaretskii
2019-04-23 11:42 ` Pedro Alves
2019-04-28 16:58 ` Joel Brobecker [this message]
2019-04-28 16:58 ` [RFA v2 1/2][master+8.3] (Windows) fix thr != nullptr assert failure in delete_thread_1 Joel Brobecker
2019-04-28 16:58 ` [RFA v2 2/2][master only] gdb/windows-nat.c: Get rid of main_thread_id global Joel Brobecker
2019-04-30 13:00 ` [v2] Windows native GDB event handling enhancement Pedro Alves
2019-04-30 21:04 ` pushed(master+8.3): " Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556470691-146942-1-git-send-email-brobecker@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox