From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67689 invoked by alias); 28 Apr 2019 16:58:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67679 invoked by uid 89); 28 Apr 2019 16:58:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=weeks, concerned, kept X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 28 Apr 2019 16:58:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3B139116F70 for ; Sun, 28 Apr 2019 12:58:13 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id SOox+cp7kBdL for ; Sun, 28 Apr 2019 12:58:13 -0400 (EDT) Received: from tron.gnat.com (tron.gnat.com [205.232.38.10]) by rock.gnat.com (Postfix) with ESMTP id 292FA116F4B for ; Sun, 28 Apr 2019 12:58:13 -0400 (EDT) Received: by tron.gnat.com (Postfix, from userid 4233) id 25810549; Sun, 28 Apr 2019 12:58:13 -0400 (EDT) From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [v2] Windows native GDB event handling enhancement Date: Sun, 28 Apr 2019 16:58:00 -0000 Message-Id: <1556470691-146942-1-git-send-email-brobecker@adacore.com> In-Reply-To: <1555453982-77808-1-git-send-email-brobecker@adacore.com> References: <1555453982-77808-1-git-send-email-brobecker@adacore.com> X-SW-Source: 2019-04/txt/msg00616.txt.bz2 Hello, This is v2 of the patch series, which now consists of 2 patches: * [RFA v2 1/2] (Windows) fix thr != nullptr assert failure in Compared to v1, it has been reduced to the essence of the fix, which is to avoid using main_thread_id during the exit-process event; and that's it. * [RFA v2 2/2] gdb/windows-nat.c: Get rid of main_thread_id global That one shold be unchanged. The part that re-instated the thread notifications for the main thread (at create-process event) and for the last thread (at exit-process event) has been excised from v1 of patch #1. I think this is the best compromise based on the discussions so far. I will personally miss the silenced notifications, but for those like me, we can enable the windows event debug logs. The reason why I kept the patches split in two is so that I can apply patch #1 on the gdb-8.3 branch as well. Patch #2 has been behaving well as far as AdaCore nightly testing is concerned, but it's only been a few weeks since we implemented it, and I think it deserves more time in master before being in a release. The patches were tested on both 32bit and 64bit native windows, using AdaCore testsuite. OK to push? Thanks, -- Joel