From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-155421-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17832 invoked by alias); 18 Apr 2019 15:04:28 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 17813 invoked by uid 89); 18 Apr 2019 15:04:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 spammy=
X-HELO: mail-wm1-f45.google.com
Received: from mail-wm1-f45.google.com (HELO mail-wm1-f45.google.com) (209.85.128.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Apr 2019 15:04:26 +0000
Received: by mail-wm1-f45.google.com with SMTP id h18so3284178wml.1        for <gdb-patches@sourceware.org>; Thu, 18 Apr 2019 08:04:26 -0700 (PDT)
Return-Path: <palves@redhat.com>
Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b])        by smtp.gmail.com with ESMTPSA id g19sm2271721wmh.17.2019.04.18.08.04.23        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);        Thu, 18 Apr 2019 08:04:23 -0700 (PDT)
Subject: Re: [RFA 1/2][master+8.3] (Windows) fix thr != nullptr assert failure in delete_thread_1
To: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
References: <1555453982-77808-1-git-send-email-brobecker@adacore.com> <1555453982-77808-2-git-send-email-brobecker@adacore.com> <f6f937cb-2e0e-d602-2015-75467bd181e8@redhat.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <395ad477-eaaf-8df2-a701-e79859b85fb1@redhat.com>
Date: Thu, 18 Apr 2019 15:04:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <f6f937cb-2e0e-d602-2015-75467bd181e8@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-04/txt/msg00326.txt.bz2

On 4/18/19 3:52 PM, Pedro Alves wrote:

>> @@ -1637,11 +1629,11 @@ get_windows_debug_event (struct target_ops *ops,
>>        else if (saw_create == 1)
>>  	{
>>  	  windows_delete_thread (ptid_t (current_event.dwProcessId, 0,
>> -					 main_thread_id),
>> -				 0, true /* main_thread_p */);
>> +					 current_event.dwThreadId),
>> +				 0);
>>  	  ourstatus->kind = TARGET_WAITKIND_EXITED;
>>  	  ourstatus->value.integer = current_event.u.ExitProcess.dwExitCode;
>> -	  thread_id = main_thread_id;
>> +	  thread_id = current_event.dwThreadId;
>>  	}
>>        break;
> 
> This looks right.

I forgot to add: reading this made me wonder -- what about gdbserver?
I looked, and while gdbserver/win32-low.c had an equivalent of main_thread_id,
it doesn't use it for EXIT_PROCESS_DEBUG_EVENT either.

Thanks,
Pedro Alves