Re: [PATCH v4 1/2] gdbserver: Haiku support

[Simon Marchi <simark@simark.ca>]

On 2026-04-23 14:59, Jérôme Duval wrote:
> Initial support was done by Trung Nguyen for GDB 15.1 for GSoC 2024:
> See blog entries https://www.haiku-os.org/tags/gdb
> Original Port repository: https://github.com/trungnt2910/gdb-haiku
> 
> I mostly adapted to the next major releases.

Hi Jérôme,

I'm just looking at the existing modified files for now, but I'll like
to look at the whole thing eventually (it's just that the number of
lines makes it scary :)).

> diff --git a/gdbserver/Makefile.in b/gdbserver/Makefile.in
> index e45c89dc..890f05cb 100644
> --- a/gdbserver/Makefile.in
> +++ b/gdbserver/Makefile.in
> @@ -592,6 +592,12 @@ gdbreplay.o: gdbreplay.cc
>  	$(ECHO_CXX) $(COMPILE.pre) $(INTERNAL_CFLAGS) $(CXXFLAGS) \
>  		-include gdbsupport/common-defs.h $(COMPILE.post) $<
>  
> +# Rule for Haiku files.  This is the same as COMPILE, but does not include
> +# server.h to avoid name clashes with Haiku system structs.
> +nat/haiku-%.o: ../gdb/nat/haiku-%.c
> +	$(ECHO_CXX) $(COMPILE.pre) $(INTERNAL_CFLAGS) $(CXXFLAGS) \
> +		$(COMPILE.post) -x c++ $<

What are the clashes? We can always rename (or namespace) things in GDB.
That would be nicer in the long run than having special rules for Haiku.

> diff --git a/include/gdb/signals.def b/include/gdb/signals.def
> index c6819b0f..0d4bb011 100644
> --- a/include/gdb/signals.def
> +++ b/include/gdb/signals.def
> @@ -196,7 +196,9 @@ SET (GDB_EXC_BREAKPOINT, 150, "EXC_BREAKPOINT", "Breakpoint")
>  
>  SET (GDB_SIGNAL_LIBRT, 151, "SIGLIBRT", "librt internal signal")
>  
> +SET (GDB_SIGNAL_SIGKILLTHR, 152, "SIGKILLTHR", "Thread killed")

Since this is non-standard (AFAIK), this could use a comment.

Simon