Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: "Jérôme Duval" <jerome.duval@gmail.com>, gdb-patches@sourceware.org
Cc: me@trungnt2910.com
Subject: Re: [PATCH v4 2/2] gdb: Haiku support
Date: Thu, 23 Apr 2026 23:13:15 -0400	[thread overview]
Message-ID: <815a9704-a21f-4862-8721-4c9217c989e7@simark.ca> (raw)
In-Reply-To: <20260423185942.7061-3-jerome.duval@gmail.com>


Oops, I had mistakenly opened 2 reply windows, here are some more
comments.

> diff --git a/gdb/configure.nat b/gdb/configure.nat
> index 38dd4179..286d2fe7 100644
> --- a/gdb/configure.nat
> +++ b/gdb/configure.nat
> @@ -74,6 +74,11 @@ case ${gdb_host} in
>      obsd*)
>  	NATDEPFILES='fork-child.o nat/fork-inferior.o inf-ptrace.o'
>  	;;
> +	haiku*)

4 spaces instead of tab, to be like the others

> +	NATDEPFILES='fork-child.o nat/fork-inferior.o \
> +		nat/haiku-debug.o nat/haiku-nat.o nat/haiku-nub-message.o \
> +		nat/haiku-osdata.o haiku-nat.o'
> +	;;
>      cygwin*)
>  	NATDEPFILES='x86-nat.o nat/x86-dregs.o windows-nat.o nat/windows-nat.o'
>  	;;
> @@ -504,6 +509,16 @@ case ${gdb_host} in
>  		;;
>  	esac
>  	;;
> +	haiku64)

Same.

Simon

      parent reply	other threads:[~2026-04-24  3:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-23 18:59 [PATCH v4 0/2] Support for Haiku/x86-64 in GDB Jérôme Duval
2026-04-23 18:59 ` [PATCH v4 1/2] gdbserver: Haiku support Jérôme Duval
2026-04-24  3:02   ` Simon Marchi
2026-04-23 18:59 ` [PATCH v4 2/2] gdb: " Jérôme Duval
2026-04-24  3:10   ` Simon Marchi
2026-04-24  3:13   ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=815a9704-a21f-4862-8721-4c9217c989e7@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=jerome.duval@gmail.com \
    --cc=me@trungnt2910.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox