From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ejakOnjd6mks5zcAWB0awg (envelope-from ) for ; Thu, 23 Apr 2026 23:03:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1776999800; bh=z7ZiMQBIgzVKMdyP5dKpdwI+ihmFBYpPtvzSajUouGI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=DX3E6j3E5JjTCotcO5qnQoH1EiC0vjt1GqmYMH2WmuXT3ipNdvfZKR88jqBdfPHQs h6MmXkxKQAPAD+kCUDZXRCY+cVNrvR9O1z8zEU8SHoETHHt4uYAY5HLdLchi2YQP0W gNYWIgzFdbK/00bGnPdD7+MtejhdFUORGm7UW7ac= Received: by simark.ca (Postfix, from userid 112) id DBD901E093; Thu, 23 Apr 2026 23:03:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=e3KjJe2h; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8FF4A1E093 for ; Thu, 23 Apr 2026 23:03:19 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 316334B99F7C for ; Fri, 24 Apr 2026 03:03:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 316334B99F7C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=e3KjJe2h Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 6161A4BABF32 for ; Fri, 24 Apr 2026 03:02:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6161A4BABF32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6161A4BABF32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776999776; cv=none; b=XFMSbfUaCxc24fzy7vtwcg9admcTqkRD3gcneR39RdzkDFssjf1TMjpJXgACJiHoN9wpyUcm/sC2A1iZJcC670i/PcetwX6syilpDk3FCpUYt6cxBkhyxrwh8bf2wNv45hmxrAiGdCLtHkL/qta2wmGGVi4WLOe2fzUj5uxqSWQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776999776; c=relaxed/simple; bh=z7ZiMQBIgzVKMdyP5dKpdwI+ihmFBYpPtvzSajUouGI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=r6YX8d69BRkTKETcGbRglGPxRBNfe65MmHrBxBJu3vTuLbvMyo246x3Tmy5Mm2dRsU2H1WPsPl4YATeLwrCiDv3IOBGJDzWcj8I1JHRtDOLnk2c0T1crpUEi5c+QP3joCC125mNoyiM6YGCa2mBd+iutJM6AssWUx1fvYaw4Hxo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6161A4BABF32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1776999775; bh=z7ZiMQBIgzVKMdyP5dKpdwI+ihmFBYpPtvzSajUouGI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=e3KjJe2hcBa2HoclyA+L15hLrTNF7HOotOHnOr39Mfifd69XoV3xlIjIbZGl6XCCi I1fkJKJMArK4OGR9V9jIeAfFjaTvvsJgv7wtqvMcjBsmi8MSef1KDUY/9df7jT1fWm nn30bS92asdSHrEVyiUYEM+4vTtU62v1A6EBcqZ0= Received: by simark.ca (Postfix) id 7EDEC1E093; Thu, 23 Apr 2026 23:02:55 -0400 (EDT) Message-ID: <361cf9e6-36a4-4d90-906e-72c99b050fcd@simark.ca> Date: Thu, 23 Apr 2026 23:02:55 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/2] gdbserver: Haiku support To: =?UTF-8?B?SsOpcsO0bWUgRHV2YWw=?= , gdb-patches@sourceware.org Cc: me@trungnt2910.com References: <20260423185942.7061-1-jerome.duval@gmail.com> <20260423185942.7061-2-jerome.duval@gmail.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20260423185942.7061-2-jerome.duval@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-04-23 14:59, Jérôme Duval wrote: > Initial support was done by Trung Nguyen for GDB 15.1 for GSoC 2024: > See blog entries https://www.haiku-os.org/tags/gdb > Original Port repository: https://github.com/trungnt2910/gdb-haiku > > I mostly adapted to the next major releases. Hi Jérôme, I'm just looking at the existing modified files for now, but I'll like to look at the whole thing eventually (it's just that the number of lines makes it scary :)). > diff --git a/gdbserver/Makefile.in b/gdbserver/Makefile.in > index e45c89dc..890f05cb 100644 > --- a/gdbserver/Makefile.in > +++ b/gdbserver/Makefile.in > @@ -592,6 +592,12 @@ gdbreplay.o: gdbreplay.cc > $(ECHO_CXX) $(COMPILE.pre) $(INTERNAL_CFLAGS) $(CXXFLAGS) \ > -include gdbsupport/common-defs.h $(COMPILE.post) $< > > +# Rule for Haiku files. This is the same as COMPILE, but does not include > +# server.h to avoid name clashes with Haiku system structs. > +nat/haiku-%.o: ../gdb/nat/haiku-%.c > + $(ECHO_CXX) $(COMPILE.pre) $(INTERNAL_CFLAGS) $(CXXFLAGS) \ > + $(COMPILE.post) -x c++ $< What are the clashes? We can always rename (or namespace) things in GDB. That would be nicer in the long run than having special rules for Haiku. > diff --git a/include/gdb/signals.def b/include/gdb/signals.def > index c6819b0f..0d4bb011 100644 > --- a/include/gdb/signals.def > +++ b/include/gdb/signals.def > @@ -196,7 +196,9 @@ SET (GDB_EXC_BREAKPOINT, 150, "EXC_BREAKPOINT", "Breakpoint") > > SET (GDB_SIGNAL_LIBRT, 151, "SIGLIBRT", "librt internal signal") > > +SET (GDB_SIGNAL_SIGKILLTHR, 152, "SIGKILLTHR", "Thread killed") Since this is non-standard (AFAIK), this could use a comment. Simon