From: Kamil Rytarowski <kamil@netbsd.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, tom@tromey.com
Subject: Re: [PATCH v2 04/10] Add netbsd_nat::pid_to_exec_file
Date: Mon, 7 Sep 2020 15:36:52 +0200 [thread overview]
Message-ID: <3562912c-2b32-2b5a-308a-d4a28d12f5d9@netbsd.org> (raw)
In-Reply-To: <20200907075741.GG853475@embecosm.com>
[-- Attachment #1.1: Type: text/plain, Size: 2488 bytes --]
On 07.09.2020 09:57, Andrew Burgess wrote:
> * Kamil Rytarowski <n54@gmx.com> [2020-09-04 02:28:59 +0200]:
>
>> gdb/ChangeLog:
>>
>> * netbsd-nat.h: Include <unistd.h>.
>> * (netbsd_nat::pid_to_exec_file): Add.
>> * netbsd-nat.c: Include <sys/types.h> and <sys/sysctl.h>.
>> * (netbsd_nat::pid_to_exec_file) Add.
>> ---
>> gdb/ChangeLog | 7 +++++++
>> gdb/nat/netbsd-nat.c | 18 ++++++++++++++++++
>> gdb/nat/netbsd-nat.h | 5 +++++
>> 3 files changed, 30 insertions(+)
>>
>> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
>> index 9e9d4e16e5d..335d6b7271f 100644
>> --- a/gdb/ChangeLog
>> +++ b/gdb/ChangeLog
>> @@ -1,3 +1,10 @@
>> +2020-09-04 Kamil Rytarowski <n54@gmx.com>
>> +
>> + * netbsd-nat.h: Include <unistd.h>.
>> + * (netbsd_nat::pid_to_exec_file): Add.
>> + * netbsd-nat.c: Include <sys/types.h> and <sys/sysctl.h>.
>> + * (netbsd_nat::pid_to_exec_file) Add.
>> +
>> 2020-09-04 Kamil Rytarowski <n54@gmx.com>
>>
>> * configure.nat (NATDEPFILES): Add nat/netbsd-nat.o when needed.
>> diff --git a/gdb/nat/netbsd-nat.c b/gdb/nat/netbsd-nat.c
>> index 2b5a4183e30..297188bb8b4 100644
>> --- a/gdb/nat/netbsd-nat.c
>> +++ b/gdb/nat/netbsd-nat.c
>> @@ -19,6 +19,24 @@
>>
>> #include "nat/netbsd-nat.h"
>>
>> +#include <sys/types.h>
>> +#include <sys/sysctl.h>
>> +
>> namespace netbsd_nat
>> {
>> +
>> +/* Return the executable file name of a process specified by PID. Returns the
>> + string in a static buffer. */
>> +
>> +char *
>> +pid_to_exec_file (pid_t pid)
>
> The convention in GDB is to document global functions in the header
> file, and leave a comment '/* See xxxx.h. */' in the source file.
>
> Thanks,
> Andrew
>
>
OK. I will do it in v3.
>> +{
>> + static char buf[PATH_MAX];
>> + int mib[4] = {CTL_KERN, KERN_PROC_ARGS, pid, KERN_PROC_PATHNAME};
>> + size_t buflen = sizeof (buf);
>> + if (::sysctl (mib, ARRAY_SIZE (mib), buf, &buflen, NULL, 0))
>> + return NULL;
>> + return buf;
>> +}
>> +
>> }
>> diff --git a/gdb/nat/netbsd-nat.h b/gdb/nat/netbsd-nat.h
>> index 5fa08746610..a5f664d95f4 100644
>> --- a/gdb/nat/netbsd-nat.h
>> +++ b/gdb/nat/netbsd-nat.h
>> @@ -20,8 +20,13 @@
>> #ifndef NAT_NETBSD_NAT_H
>> #define NAT_NETBSD_NAT_H
>>
>> +#include <unistd.h>
>> +
>> namespace netbsd_nat
>> {
>> +
>> +extern char *pid_to_exec_file (pid_t pid);
>> +
>> }
>>
>> #endif
>> --
>> 2.28.0
>>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-09-07 13:40 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 0:28 [PATCH v2 00/10] Add minimal NetBSD/amd64 gdbserver support Kamil Rytarowski
2020-09-04 0:28 ` [PATCH v2 01/10] Add handle_eintr to wrap EINTR handling in syscalls Kamil Rytarowski
2020-09-07 14:06 ` Simon Marchi
2020-09-07 14:59 ` Kamil Rytarowski
2020-10-12 17:56 ` [PATCH] gdb::handle_eintr, remove need to specify return type (Re: [PATCH v2 01/10] Add handle_eintr to wrap EINTR handling in syscalls) Pedro Alves
2020-10-13 13:43 ` Kamil Rytarowski
2020-10-13 14:17 ` [PATCH v2] gdb::handle_eintr, remove need to specify return type Pedro Alves
2020-10-13 14:54 ` Kamil Rytarowski
2020-10-16 20:51 ` Tom Tromey
2020-10-26 14:00 ` Pedro Alves
2020-10-26 14:20 ` Tom Tromey
2020-10-26 18:59 ` Pedro Alves
2020-09-04 0:28 ` [PATCH v2 02/10] Register a placeholder for NetBSD shared functions in gdb/nat Kamil Rytarowski
2020-09-07 18:44 ` Simon Marchi
2020-09-07 19:49 ` Kamil Rytarowski
2020-09-04 0:28 ` [PATCH v2 03/10] Build nat/netbsd-nat.o for the NetBSD native target Kamil Rytarowski
2020-09-04 0:28 ` [PATCH v2 04/10] Add netbsd_nat::pid_to_exec_file Kamil Rytarowski
2020-09-07 7:57 ` Andrew Burgess
2020-09-07 13:36 ` Kamil Rytarowski [this message]
2020-09-07 18:48 ` Simon Marchi
2020-09-07 18:47 ` Simon Marchi
2020-09-07 19:51 ` Kamil Rytarowski
2020-09-04 0:29 ` [PATCH v2 05/10] Add gdb/nat common functions for listing threads Kamil Rytarowski
2020-09-07 18:59 ` Simon Marchi
2020-09-07 19:57 ` Kamil Rytarowski
2020-09-04 0:29 ` [PATCH v2 06/10] Add netbsd_nat::enable_proc_events in gdb/nat Kamil Rytarowski
2020-09-04 0:29 ` [PATCH v2 07/10] Add a common utility function to read and write siginfo_t in inferior Kamil Rytarowski
2020-09-04 0:29 ` [PATCH v2 08/10] Avoid double free in startup_inferior Kamil Rytarowski
2020-09-07 19:19 ` Simon Marchi
2020-09-08 0:54 ` Kamil Rytarowski
2020-09-08 2:21 ` Simon Marchi
2020-09-04 0:29 ` [PATCH v2 09/10] Switch local native code to gdb/nat shared functions Kamil Rytarowski
2020-09-07 19:24 ` Simon Marchi
2020-09-08 0:04 ` Kamil Rytarowski
2020-09-04 0:29 ` [PATCH v2 10/10] Add minimal and functional NetBSD/amd64 gdbserver Kamil Rytarowski
2020-09-07 19:58 ` Simon Marchi
2020-09-08 0:03 ` Kamil Rytarowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3562912c-2b32-2b5a-308a-d4a28d12f5d9@netbsd.org \
--to=kamil@netbsd.org \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox