From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.netbsd.org (mail.NetBSD.org [IPv6:2001:470:a085:999::25]) by sourceware.org (Postfix) with ESMTPS id BE97038708DB for ; Mon, 7 Sep 2020 13:40:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BE97038708DB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=netbsd.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kamil@netbsd.org Received: from [IPv6:::1] (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id C1A7184D3A; Mon, 7 Sep 2020 13:40:00 +0000 (UTC) Subject: Re: [PATCH v2 04/10] Add netbsd_nat::pid_to_exec_file To: Andrew Burgess Cc: gdb-patches@sourceware.org, tom@tromey.com References: <20200904002905.13616-1-n54@gmx.com> <20200904002905.13616-5-n54@gmx.com> <20200907075741.GG853475@embecosm.com> From: Kamil Rytarowski Autocrypt: addr=kamil@netbsd.org; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCNLYW1pbCBSeXRh cm93c2tpIDxrYW1pbEBOZXRCU0Qub3JnPokCOQQTAQgAIwUCVbKF6wIbIwcLCQgHAwIBBhUI AgkKCwQWAgMBAh4BAheAAAoJEEuzCOmwLnZsrgwQAMdXTXDWkxtUciFgBnioE6hvZYOBV7Xa Gh3dwgVvS5rLwwq5ob1R9qdtCGMYxdaCAQCzo2hhUfe9ts11/Q4Pg0aDAb5CfdVVTmyvLMu+ gtK99t/sG4SfCdn8Bb8rCfRRDpkTq1cAGy6pp7rxyMrFBITTbdBWVcWdEdlMhEZtV8Z1BNDI kwEwZkYnM1UxOGW4rJNjNU+hBjNAscCTwBSbpG6NV1oBbgmgJ1PfaPCeAmGTLZyI57VLuFJy kR0Jlj8Ui7dAaJgO1WYdmvL+48s0N2QGEoHnrf50xoO34LlrIBUsCLmhtjWhZiuj0meCxNTr 5YpdBP13b2i64OCruH8/M4IO85GAIWxIMMv510rge9qSe38NHCzSmn9zcjFwVXIh9flZi7PK eqOP3yah6r1ZIBY68If/2FtvwDptUi1NHoSpN+dt0kRg26hDqMFOg+Jc6o7Wtm+3vFNDhU4I 8HkjDr62VlbHBxe6gDgVELcecWgXOydKgdrQhOPwCBJkPJigifsIz4EZQnyI3CchFja3qR9J Vo4iXwqAi6xN4RD0PS775JYDh56qUaaUsEctQ/D6Xm7Bbdv1VPlsYs/9uXxc/jWVhkd1sDn2 KZ3kv7uo04DoejVGWK9B4XEZ1ufRPzmlV0SYohX34ouLBq5Q6wbyw6+hUM+yM9RcvgkOCVgB laejuQINBFVwUF8BEAC61vNvzAAcYvkU89YoStDcGyun1ENNWpHOnuQEw613/Xgys6xZbKKa Xhee8Fiwm6FlaiYWh66Vw5cA+hMna9PDp6tZi106JnKZ9DcYxanHOCQ5V42OwUX0BDfwUIwq YgOz12Cf4pdIheVkDfiSEot3XrdI3lT8od9iWeehx5zfW77utVrWGUXkMFJKmiKzxyzjV+gF gLk2wH+L7KoYiV/MfLukLa7mTJAK4mi0sfjLStPlf5gELvPtyooKG0gs0MbDSG2qmzb1/A4Y ET8Vaa7wJulIePym+Du5TJBwptls0KEF9a04kp2Oc2zlUd/Z5z3lLBiZaXpfProbz3Ydjg4O 2+XTn+SHSq10l3agjiAkGwHH83Xnzn/clg3iTvwYgdOcwvfEnJ1FGz3DAzcBd/+IMaszJjuo dBVckt07mc97sseDjy+vIIyQGdMzDmI0U9UK7nDUFpnIfG5LYe+myBS1CgFrZAQ/WNg0j7aq CiIgbhVAOFi2sPRYlph2L8LZRUPFHLTt23vdJXdFDuKM6JSvPiDf914UpjXr/WSwT43lJzlO O3zgKGM7eclFsetDF3p0I4SVHvR7dHbIC5IHibssmk7bQgH0K1aGUX/QC18v3VY7wYYaotYH RnTiGbBGz+XxPhZYiXKQuyFu6dY3qOw/VjbsV6KVNn49z2Zg4RQV8QARAQABiQIfBBgBCAAJ BQJVcFBfAhsMAAoJEEuzCOmwLnZs9rIP/2MTyZ0252u51LFsMHa9/ylTyvl+UKq8iR852lkZ X9bH9nH4cUcen5vZo0EZI3IVOemHUq71u+DTq8PSj5vtJ0DW+sGBEbjW3Q4IjJ+96PPrlemK fYS0KWVwEzzNQLEejjduU43x83DvQ/URzSWgGnhMBqXUyJdsHyTFFNFwQ9U71gX00+wXHJyh aXRlK+7gRKtCWuNFtW/5bQXL9epxDAS0POIVAdBc1FtPLwg08Pj0KwHsGQpEr5/W8ybDtLF+ zISHIKCj1lZ8dv/7D1PmH5SEXzsv+bbzvPtb6zhoIA8HONshaG2eAYknAiCJZ0gj0npgktwc u9VkvDvHMD9+VyNzRV/M6Ak4nDeEG6QecTPv8IqCcAHDI27nY/49BvFVOJOMwqbTp5Xvfa71 ksP1mARrN+bIYMfOy7OhfCxGeZydvBhgCLKdL698aXmgy0xrmrOw+GXO69GVcebOvxWMXxz1 FOG/JnLIe1ZgCo2YF5wy8zTCGKCMx6gAwnku2nJmDGNsePVedV00FmB8mQ7Oxz+3B9+LtFim FHHR33PlRnViXlG+XTm9NontiGE0LvG4TzIY5CYNSw8PBao795dQMSsmMI4FHlvTIgupE9g1 PQWP+2H2C0RtnLUanRNUGRkze1+MNG7jc+fqJIo5s7+PSs26rUvA38QzEOJ95k7hdJty Message-ID: <3562912c-2b32-2b5a-308a-d4a28d12f5d9@netbsd.org> Date: Mon, 7 Sep 2020 15:36:52 +0200 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200907075741.GG853475@embecosm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8rLs2ntJcgldDy7M6725tvT9Rs014FAaP" X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Sep 2020 13:40:06 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8rLs2ntJcgldDy7M6725tvT9Rs014FAaP Content-Type: multipart/mixed; boundary="sAY7CFhRbCdy3Kc0SamWYIUnEbahmM9me"; protected-headers="v1" From: Kamil Rytarowski To: Andrew Burgess Cc: gdb-patches@sourceware.org, tom@tromey.com Message-ID: <3562912c-2b32-2b5a-308a-d4a28d12f5d9@netbsd.org> Subject: Re: [PATCH v2 04/10] Add netbsd_nat::pid_to_exec_file References: <20200904002905.13616-1-n54@gmx.com> <20200904002905.13616-5-n54@gmx.com> <20200907075741.GG853475@embecosm.com> In-Reply-To: <20200907075741.GG853475@embecosm.com> --sAY7CFhRbCdy3Kc0SamWYIUnEbahmM9me Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 07.09.2020 09:57, Andrew Burgess wrote: > * Kamil Rytarowski [2020-09-04 02:28:59 +0200]: >=20 >> gdb/ChangeLog: >> >> * netbsd-nat.h: Include . >> * (netbsd_nat::pid_to_exec_file): Add. >> * netbsd-nat.c: Include and . >> * (netbsd_nat::pid_to_exec_file) Add. >> --- >> gdb/ChangeLog | 7 +++++++ >> gdb/nat/netbsd-nat.c | 18 ++++++++++++++++++ >> gdb/nat/netbsd-nat.h | 5 +++++ >> 3 files changed, 30 insertions(+) >> >> diff --git a/gdb/ChangeLog b/gdb/ChangeLog >> index 9e9d4e16e5d..335d6b7271f 100644 >> --- a/gdb/ChangeLog >> +++ b/gdb/ChangeLog >> @@ -1,3 +1,10 @@ >> +2020-09-04 Kamil Rytarowski >> + >> + * netbsd-nat.h: Include . >> + * (netbsd_nat::pid_to_exec_file): Add. >> + * netbsd-nat.c: Include and . >> + * (netbsd_nat::pid_to_exec_file) Add. >> + >> 2020-09-04 Kamil Rytarowski >> >> * configure.nat (NATDEPFILES): Add nat/netbsd-nat.o when needed. >> diff --git a/gdb/nat/netbsd-nat.c b/gdb/nat/netbsd-nat.c >> index 2b5a4183e30..297188bb8b4 100644 >> --- a/gdb/nat/netbsd-nat.c >> +++ b/gdb/nat/netbsd-nat.c >> @@ -19,6 +19,24 @@ >> >> #include "nat/netbsd-nat.h" >> >> +#include >> +#include >> + >> namespace netbsd_nat >> { >> + >> +/* Return the executable file name of a process specified by PID. Re= turns the >> + string in a static buffer. */ >> + >> +char * >> +pid_to_exec_file (pid_t pid) >=20 > The convention in GDB is to document global functions in the header > file, and leave a comment '/* See xxxx.h. */' in the source file. >=20 > Thanks, > Andrew >=20 >=20 OK. I will do it in v3. >> +{ >> + static char buf[PATH_MAX]; >> + int mib[4] =3D {CTL_KERN, KERN_PROC_ARGS, pid, KERN_PROC_PATHNAME};= >> + size_t buflen =3D sizeof (buf); >> + if (::sysctl (mib, ARRAY_SIZE (mib), buf, &buflen, NULL, 0)) >> + return NULL; >> + return buf; >> +} >> + >> } >> diff --git a/gdb/nat/netbsd-nat.h b/gdb/nat/netbsd-nat.h >> index 5fa08746610..a5f664d95f4 100644 >> --- a/gdb/nat/netbsd-nat.h >> +++ b/gdb/nat/netbsd-nat.h >> @@ -20,8 +20,13 @@ >> #ifndef NAT_NETBSD_NAT_H >> #define NAT_NETBSD_NAT_H >> >> +#include >> + >> namespace netbsd_nat >> { >> + >> +extern char *pid_to_exec_file (pid_t pid); >> + >> } >> >> #endif >> -- >> 2.28.0 >> --sAY7CFhRbCdy3Kc0SamWYIUnEbahmM9me-- --8rLs2ntJcgldDy7M6725tvT9Rs014FAaP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl9WN4cACgkQS7MI6bAu dmxF5w/+JM+DCdpFfDdChVzuHABF2Vq+Y0Wcc2JEsRZXV6WWUPv6Y8It+E5uimjA qj25zjVwT51ABWj4gEaBHDYDub5tNzqUrKAL7V6dw9JN/MPlN9ag9hEn7AUFOLZP 7sZXFSvTmjVDeRnu0kqQ6uUEYVYpxuxr8/Dus5A5xIHKtZqaHCzzpt3ezwWqwGOT jLbY3/61lKYbps+avQHz3wSERmMK9mnOhmRv07avf3Xjx6KuEWoXbF88j2okyjWV 6of4pHaRryeETJLFAowwZrd5UhpK4dg9Q10FuBF8wCSJxWZWo6H+TMOxfBPYdvmL sSXmMzwQooqrKbKAfLMbcZc9zCAEqRQ1dQAu1D0Fn9alFgblD/LRNNqFWwnQyibo z/pMQf5SOmvy41yGBv+h8oJ5vloneSGZ/LaRJR3dA2wQsPULsRSNGv/SDvfLIW7u nf6iP0bMlnf1iAHECInEfM2UnxbQcbDJZvyUYKjJswTD4isARd8eLjp7jIrxGDws huFQPuOT587iWXVmuUzLMz/JSDr5FNLMxuEhEUofEqdDURs1ZI0l1xnx3orX7yCU 7pITlxbtZS5hJ+/+i2/DorqXONRkaj9oH0mB5GnjzuxCBVkiBTgUf85nopRwrw3M hmrnajagKtYQURxqP/gnxJwopgA59PlZ2M9K72uN6WG+MN5KQZI= =V3sd -----END PGP SIGNATURE----- --8rLs2ntJcgldDy7M6725tvT9Rs014FAaP--