Re: [PATCH 2/2] gdb: remove complaint_interceptor::g_complaint_interceptor

[Simon Marchi <simon.marchi@polymtl.ca>]

On 5/21/26 10:34 AM, Tom Tromey wrote:
>>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:
> 
> Simon> From: Simon Marchi <simon.marchi@polymtl.ca>
> Simon> The thread_local g_complaint_interceptor pointer is unnecessary.  The
> Simon> complaint_interceptor constructor registers itself as the warning hook
> Simon> via m_saved_warning_hook (this), so when complaint_internal dispatches
> Simon> through the warning hook, it lands in complaint_interceptor::warn with
> Simon> 'this' already pointing at the registered interceptor.  Inside warn,
> Simon> g_complaint_interceptor and 'this' always refer to the same object.
> 
> Simon> Replace g_complaint_interceptor->m_complaints with m_complaints in
> Simon> complaint_interceptor::warn and remove g_complaint_interceptor.
> 
> Ok.
> Approved-By: Tom Tromey <tom@tromey.com>

Thanks, pushed both patches.

> I don't remember the code too well but I do wonder if we should just
> have each set of complaints be completely independent and emit them all
> at some spot guaranteed to be on the main thread.  Like, instead of
> 'complaint' function, only expose a method on some object.

I'm afraid I don't understand your suggestion.

> OTOH I don't think we should spend any more time on complaints than is
> strictly necessary.

Agreed.

Simon