From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id HXXsJkhGD2pGHA0AWB0awg (envelope-from ) for ; Thu, 21 May 2026 13:52:08 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=KSkSpCVU; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8C5FA1E024; Thu, 21 May 2026 13:52:08 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DD1C71E024 for ; Thu, 21 May 2026 13:52:07 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 60AD44BAD141 for ; Thu, 21 May 2026 17:52:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 60AD44BAD141 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=KSkSpCVU Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 5173A4BA543C for ; Thu, 21 May 2026 17:51:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5173A4BA543C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5173A4BA543C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779385903; cv=none; b=lBy26HiSnTFdaWLw5Vd4ogCZorkP4jm8CVuCLoaIPM0iaAQNSgQwXL6zGMAy8zrQ9wT7fphn5bDPyfOH66OPSbG1tuYhMl6yFiJuLDtGrUhoEATmVMgI8hrosATr61Ic/QEKMTiC6eJTisoYw1GywoVDuHt5YggysrtfOJAd/MQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779385903; c=relaxed/simple; bh=Gm7stDu8nCEy/49kEa5FrJA2Qip5PzXNL90fktbggFk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=K4WPSaxp1GmyxV0BdaiJ2yYOBYKHSsNT0Y4mfn+dq1jNdb1FtFBYaRdsXbr9GSVmSKqVB3abopwDKP7vNgQDLXsoV/azXBxTBmEbEhUBoBU1UOcEcy0bHBNIjS2G/kJNfUAK7A3xqRGI2AfYQ9CLbjOfCYrZlAp0sjlT7V9F0tE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=KSkSpCVU DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5173A4BA543C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 64LHpbdN069868 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 May 2026 13:51:42 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 64LHpbdN069868 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1779385902; bh=qUTapFxw1UF+bjHRCGZTfecFQfswdtGlrLXlRL59JCE=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=KSkSpCVUG02V42Nl+jkTGNo+Tyf5fvMXNR8/4eFyuBsJLOLYXiMYSRv7zGN1pDOjC 5tqQxlvyHrZkR2BCaJLfCooIPnWsjtQQYXoh2wOg2KIGLJsjgmEGLd8I7LNdVXbe6b UBuAiDEErJGhlsOKxQJSVIb98p/JBYw5QNfS8pU3UI8EBmsnskkcHvAXNI5C2jBG5X xlW3LyGV325skB00hqLcSEYGSHyETSZseUjZFHQBkJ8CvUr1WZnN2u7ApGcbjeGtp6 pXWs5wFUFObV9CXJF4rY0cBbJqwwA+hJAeCvpolyVlOrb++OYAkFbUJ23MbI3sz2qy +80s3yl++dEhw== Received: by simark.ca (Postfix) id AF92A1E024; Thu, 21 May 2026 13:51:37 -0400 (EDT) Message-ID: <3463c605-01ed-447b-8019-e311826a5d64@polymtl.ca> Date: Thu, 21 May 2026 13:51:37 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] gdb: remove complaint_interceptor::g_complaint_interceptor To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260521040112.1618748-1-simon.marchi@polymtl.ca> <20260521040112.1618748-2-simon.marchi@polymtl.ca> <877bowal22.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <877bowal22.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 21 May 2026 17:51:37 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/21/26 10:34 AM, Tom Tromey wrote: >>>>>> "Simon" == simon marchi writes: > > Simon> From: Simon Marchi > Simon> The thread_local g_complaint_interceptor pointer is unnecessary. The > Simon> complaint_interceptor constructor registers itself as the warning hook > Simon> via m_saved_warning_hook (this), so when complaint_internal dispatches > Simon> through the warning hook, it lands in complaint_interceptor::warn with > Simon> 'this' already pointing at the registered interceptor. Inside warn, > Simon> g_complaint_interceptor and 'this' always refer to the same object. > > Simon> Replace g_complaint_interceptor->m_complaints with m_complaints in > Simon> complaint_interceptor::warn and remove g_complaint_interceptor. > > Ok. > Approved-By: Tom Tromey Thanks, pushed both patches. > I don't remember the code too well but I do wonder if we should just > have each set of complaints be completely independent and emit them all > at some spot guaranteed to be on the main thread. Like, instead of > 'complaint' function, only expose a method on some object. I'm afraid I don't understand your suggestion. > OTOH I don't think we should spend any more time on complaints than is > strictly necessary. Agreed. Simon