From: Tom Tromey <tom@tromey.com>
To: simon.marchi@polymtl.ca
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb: lock complaint_mutex in clear_complaints
Date: Thu, 21 May 2026 08:25:53 -0600 [thread overview]
Message-ID: <87bje8alfy.fsf@tromey.com> (raw)
In-Reply-To: <20260521040112.1618748-1-simon.marchi@polymtl.ca> (simon marchi's message of "Thu, 21 May 2026 00:00:48 -0400")
>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:
Simon> This points to clear_complaints touching the global counters map in the
Simon> main thread without holding a lock, while a background thread touched
Simon> the map in a worker thread while holding the lock complaint_mutex.
Simon> Fix this by holding the complaint_mutex lock in clear_complaints.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2026-05-21 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 4:00 simon.marchi
2026-05-21 4:00 ` [PATCH 2/2] gdb: remove complaint_interceptor::g_complaint_interceptor simon.marchi
2026-05-21 14:34 ` Tom Tromey
2026-05-21 17:51 ` Simon Marchi
2026-05-21 14:25 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bje8alfy.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox