* [PATCH] Call remote_check_symbols() even if only symbol-file (not file) has been given
@ 2014-02-01 7:21 Christian Eggers
2014-02-03 2:19 ` Joel Brobecker
0 siblings, 1 reply; 2+ messages in thread
From: Christian Eggers @ 2014-02-01 7:21 UTC (permalink / raw)
To: gdb-patches; +Cc: Pedro Alves, Yao Qi
The Eclipse "C/C++ GDB Hardware Debugging" plugin runs only
the "symbol-file" command. In this case, remote_check_symbols()
is not called and no qSymbol:: packet is sent to the gdbserver
(OpenOCD in my case).
2014-02-01 Christian Eggers <ceggers@gmx.de>
* remote.c (remote_start_remote): Call remote_check_symbols() even if only symbol-file (not file) has been given.
diff --git a/gdb/remote.c b/gdb/remote.c
index 7297df0..40cc143 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -3668,7 +3668,7 @@ remote_start_remote (int from_tty, struct target_ops *target, int extended_p)
/* If we connected to a live target, do some additional setup. */
if (target_has_execution)
{
- if (exec_bfd) /* No use without an exec file. */
+ if (symfile_objfile) /* No use without an symbol-file. */
remote_check_symbols ();
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Call remote_check_symbols() even if only symbol-file (not file) has been given
2014-02-01 7:21 [PATCH] Call remote_check_symbols() even if only symbol-file (not file) has been given Christian Eggers
@ 2014-02-03 2:19 ` Joel Brobecker
0 siblings, 0 replies; 2+ messages in thread
From: Joel Brobecker @ 2014-02-03 2:19 UTC (permalink / raw)
To: Christian Eggers; +Cc: gdb-patches, Pedro Alves, Yao Qi
Hello Christian,
On Sat, Feb 01, 2014 at 08:21:31AM +0100, Christian Eggers wrote:
> The Eclipse "C/C++ GDB Hardware Debugging" plugin runs only
> the "symbol-file" command. In this case, remote_check_symbols()
> is not called and no qSymbol:: packet is sent to the gdbserver
> (OpenOCD in my case).
>
> 2014-02-01 Christian Eggers <ceggers@gmx.de>
>
> * remote.c (remote_start_remote): Call remote_check_symbols() even if only symbol-file (not file) has been given.
With my Patch Champion hat...
The line above in the ChangeLog is too long and needs to be split at
around 70-80 characters.
> diff --git a/gdb/remote.c b/gdb/remote.c
> index 7297df0..40cc143 100644
> --- a/gdb/remote.c
> +++ b/gdb/remote.c
> @@ -3668,7 +3668,7 @@ remote_start_remote (int from_tty, struct target_ops *target, int extended_p)
> /* If we connected to a live target, do some additional setup. */
> if (target_has_execution)
> {
> - if (exec_bfd) /* No use without an exec file. */
> + if (symfile_objfile) /* No use without an symbol-file. */
> remote_check_symbols ();
> }
"a symbol-file" (instead of "an")?
--
Joel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-03 2:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-01 7:21 [PATCH] Call remote_check_symbols() even if only symbol-file (not file) has been given Christian Eggers
2014-02-03 2:19 ` Joel Brobecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox