From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32686 invoked by alias); 3 Feb 2014 02:19:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32675 invoked by uid 89); 3 Feb 2014 02:19:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 03 Feb 2014 02:19:01 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1E5CB1160F5; Sun, 2 Feb 2014 21:19:00 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id i+v1NDY-goEZ; Sun, 2 Feb 2014 21:19:00 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7C2E51160F2; Sun, 2 Feb 2014 21:18:59 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 4871DE0D03; Mon, 3 Feb 2014 06:18:56 +0400 (RET) Date: Mon, 03 Feb 2014 02:19:00 -0000 From: Joel Brobecker To: Christian Eggers Cc: gdb-patches@sourceware.org, Pedro Alves , Yao Qi Subject: Re: [PATCH] Call remote_check_symbols() even if only symbol-file (not file) has been given Message-ID: <20140203021856.GB4689@adacore.com> References: <3438987.Z4RkDDzs8O@p2130> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3438987.Z4RkDDzs8O@p2130> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-02/txt/msg00011.txt.bz2 Hello Christian, On Sat, Feb 01, 2014 at 08:21:31AM +0100, Christian Eggers wrote: > The Eclipse "C/C++ GDB Hardware Debugging" plugin runs only > the "symbol-file" command. In this case, remote_check_symbols() > is not called and no qSymbol:: packet is sent to the gdbserver > (OpenOCD in my case). > > 2014-02-01 Christian Eggers > > * remote.c (remote_start_remote): Call remote_check_symbols() even if only symbol-file (not file) has been given. With my Patch Champion hat... The line above in the ChangeLog is too long and needs to be split at around 70-80 characters. > diff --git a/gdb/remote.c b/gdb/remote.c > index 7297df0..40cc143 100644 > --- a/gdb/remote.c > +++ b/gdb/remote.c > @@ -3668,7 +3668,7 @@ remote_start_remote (int from_tty, struct target_ops *target, int extended_p) > /* If we connected to a live target, do some additional setup. */ > if (target_has_execution) > { > - if (exec_bfd) /* No use without an exec file. */ > + if (symfile_objfile) /* No use without an symbol-file. */ > remote_check_symbols (); > } "a symbol-file" (instead of "an")? -- Joel