From: "Eli Zaretskii" <eliz@is.elta.co.il>
To: orjan.friberg@axis.com
Cc: gdb-patches@sources.redhat.com, drow@mvista.com
Subject: Re: [RFC]: Solib search (Was: Re: Cross solib support; continued)
Date: Tue, 27 Nov 2001 08:00:00 -0000 [thread overview]
Message-ID: <3405-Tue27Nov2001175932+0200-eliz@is.elta.co.il> (raw)
In-Reply-To: <3C03AB51.DB27B3D4@axis.com>
> Date: Tue, 27 Nov 2001 16:03:45 +0100
> From: Orjan Friberg <orjan.friberg@axis.com>
>
> + /* If the search in solib_absolute_prefix failed, and the path name is
> + absolute at this point, make it relative. (openp will try and open the
> + file according to its absolute path otherwise, which is not what we want.)
> + Affects all subsequent searches for this solib. */
> + if (found_file < 0 && IS_DIR_SEPARATOR (in_pathname[0]))
> + in_pathname++;
This is not how one should test for an absoulte file name portably,
and incrementing in_pathname by one is not how you portably make it a
relative file name. I suggest to use IS_ABSOLUTE_PATH for the first
and this for the second:
while (!IS_DIR_SEPARATOR (*in_pathname++))
;
Please note that these portable macros are described in gdbint.texinfo
(node "Coding", subsection about portable coding).
WARNING: multiple messages have this Message-ID
From: "Eli Zaretskii" <eliz@is.elta.co.il>
To: orjan.friberg@axis.com
Cc: gdb-patches@sources.redhat.com, drow@mvista.com
Subject: Re: [RFC]: Solib search (Was: Re: Cross solib support; continued)
Date: Wed, 14 Nov 2001 15:22:00 -0000 [thread overview]
Message-ID: <3405-Tue27Nov2001175932+0200-eliz@is.elta.co.il> (raw)
Message-ID: <20011114152200.b6Qxc0CsUAx5GYWRNW5_5Uj8U_GkgPaf9l9aXp42u7c@z> (raw)
In-Reply-To: <3C03AB51.DB27B3D4@axis.com> (message from Orjan Friberg on Tue, 27 Nov 2001 16:03:45 +0100)
> Date: Tue, 27 Nov 2001 16:03:45 +0100
> From: Orjan Friberg <orjan.friberg@axis.com>
>
> + /* If the search in solib_absolute_prefix failed, and the path name is
> + absolute at this point, make it relative. (openp will try and open the
> + file according to its absolute path otherwise, which is not what we want.)
> + Affects all subsequent searches for this solib. */
> + if (found_file < 0 && IS_DIR_SEPARATOR (in_pathname[0]))
> + in_pathname++;
This is not how one should test for an absoulte file name portably,
and incrementing in_pathname by one is not how you portably make it a
relative file name. I suggest to use IS_ABSOLUTE_PATH for the first
and this for the second:
while (!IS_DIR_SEPARATOR (*in_pathname++))
;
Please note that these portable macros are described in gdbint.texinfo
(node "Coding", subsection about portable coding).
next prev parent reply other threads:[~2001-11-27 8:00 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3BEAA3A0.586B3046@axis.com>
[not found] ` <20011108110955.A12240@nevyn.them.org>
2001-11-06 10:49 ` Cross solib support; continued Orjan Friberg
2001-11-06 11:57 ` Kevin Buettner
2001-11-27 7:03 ` [RFC]: Solib search (Was: Re: Cross solib support; continued) Orjan Friberg
2001-11-14 12:49 ` Orjan Friberg
2001-11-27 7:12 ` Daniel Jacobowitz
2001-11-14 12:59 ` Daniel Jacobowitz
2001-11-14 13:21 ` Orjan Friberg
2001-11-14 13:53 ` Daniel Jacobowitz
2001-11-14 18:20 ` Orjan Friberg
2001-11-27 10:26 ` Orjan Friberg
2001-11-27 10:45 ` Daniel Jacobowitz
2001-11-14 18:28 ` Daniel Jacobowitz
2001-11-14 18:33 ` Orjan Friberg
2001-11-27 11:15 ` Orjan Friberg
2001-11-27 11:29 ` Daniel Jacobowitz
2001-11-14 18:55 ` Daniel Jacobowitz
2001-11-16 13:47 ` Orjan Friberg
2001-11-28 1:03 ` Orjan Friberg
2001-11-27 15:44 ` Kevin Buettner
2001-11-15 8:00 ` Daniel Jacobowitz
2001-11-15 9:16 ` Kevin Buettner
2001-11-27 16:00 ` Kevin Buettner
2001-11-27 15:47 ` Daniel Jacobowitz
2001-11-15 8:00 ` Kevin Buettner
2001-11-27 7:43 ` Daniel Jacobowitz
2001-11-27 7:36 ` Orjan Friberg
2001-11-27 8:00 ` Eli Zaretskii [this message]
2001-11-14 15:22 ` Eli Zaretskii
2001-11-27 10:16 ` Orjan Friberg
2001-11-14 18:14 ` Orjan Friberg
2001-11-14 20:58 ` Eli Zaretskii
2001-11-27 12:42 ` Eli Zaretskii
2001-11-28 0:55 ` Orjan Friberg
2001-11-16 13:24 ` Orjan Friberg
2001-11-28 2:00 ` Orjan Friberg
2001-11-16 14:02 ` Orjan Friberg
2001-11-17 2:18 ` Eli Zaretskii
2001-11-28 8:37 ` Eli Zaretskii
2001-11-28 9:43 ` Orjan Friberg
2001-11-17 4:03 ` Orjan Friberg
2001-11-17 12:37 ` Eli Zaretskii
2001-11-29 5:52 ` Orjan Friberg
2001-11-19 11:44 ` Orjan Friberg
2001-12-03 17:19 ` Kevin Buettner
2001-12-04 1:35 ` Orjan Friberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3405-Tue27Nov2001175932+0200-eliz@is.elta.co.il \
--to=eliz@is.elta.co.il \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=orjan.friberg@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox