From: Pedro Alves <pedro@palves.net>
To: Don Breazeal <donb@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3] Optimize memory_xfer_partial for remote
Date: Thu, 30 Jun 2016 23:44:00 -0000 [thread overview]
Message-ID: <339ce1ec-0551-a44f-9f39-c7e0f378a250@palves.net> (raw)
In-Reply-To: <1467326424-139115-1-git-send-email-donb@codesourcery.com>
On 06/30/2016 11:40 PM, Don Breazeal wrote:
> Hi Pedro,
> Here is v3 of the patch. Differences from v2 include returning
> ULONGEST_MAX instead of 4096 from the default target function
> and using TARGET_DEFAULT_RETURN instead of TARGET_DEFAULT_FUNCTION
> in the definition of to_get_memory_xfer_limit.
>
> I re-ran the testsuite with native and native-gdbserver and saw no
> regressions. I also verified that the behavior of the memory transfers
> was as expected for the remote and native targets.
>
> Does this one look good-to-go?
Yes, looks good.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-06-30 23:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 19:02 [PATCH] " Don Breazeal
2016-06-20 15:31 ` [PING] " Don Breazeal
2016-06-20 19:25 ` Pedro Alves
2016-06-21 10:15 ` Yao Qi
2016-06-24 21:21 ` [PATCH v2] " Don Breazeal
2016-06-24 22:23 ` Pedro Alves
2016-06-27 20:23 ` Don Breazeal
2016-06-30 17:06 ` Pedro Alves
2016-06-30 17:45 ` Don Breazeal
2016-06-30 18:40 ` Pedro Alves
2016-06-30 22:40 ` [PATCH v3] " Don Breazeal
2016-06-30 23:44 ` Pedro Alves [this message]
2016-07-01 18:24 ` [pushed] " Don Breazeal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=339ce1ec-0551-a44f-9f39-c7e0f378a250@palves.net \
--to=pedro@palves.net \
--cc=donb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox