From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16712 invoked by alias); 30 Jun 2016 23:44:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16699 invoked by uid 89); 30 Jun 2016 23:44:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f45.google.com Received: from mail-wm0-f45.google.com (HELO mail-wm0-f45.google.com) (74.125.82.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 30 Jun 2016 23:44:37 +0000 Received: by mail-wm0-f45.google.com with SMTP id r201so6844224wme.1 for ; Thu, 30 Jun 2016 16:44:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=qbvoNMElSMV/ixNC1EAvht31wq23ukCTFD1WXTfWZng=; b=aNo9NhYRkvYmMS5krl5756rR1Z23QVBWbPSiJ5kkHYDrHAtRtkpu/ysmKBemOKrBfe 4F1qB96MVoemJZ0khBEhCnwxyQ6UUw9lW26vmMlypTEY6J0X6Fw0QxnwICnuVPVEp8D1 y6Zb413YepzDaFFniZAXA6iZfxZ9+lIUV4QocMQtpBFf/qpOc1UR18+duYdiAUXFh0r0 pgAzzTHXmF1MMPA1xoddNdG0UmctIY1Wbojr9WkklsN3bJLhkA/yz9nggSLMYszFVKNb tLFieLKV4grmTuUNfRducGXFmkpsHmEHnoLm0Lt4tT/U9jocZW/S6TzJjRthG8NBsryV Jeww== X-Gm-Message-State: ALyK8tIzGK8Ri4uoTJNSlT/u/tqYqk6btKL/jPFXnEsbODnphV8E2L8cvwJgRLAC97eupQ== X-Received: by 10.194.242.37 with SMTP id wn5mr549287wjc.135.1467329839562; Thu, 30 Jun 2016 16:37:19 -0700 (PDT) Received: from ?IPv6:2001:8a0:f91e:8801:4eeb:42ff:feef:f164? ([2001:8a0:f91e:8801:4eeb:42ff:feef:f164]) by smtp.gmail.com with ESMTPSA id n26sm258844wmi.3.2016.06.30.16.37.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jun 2016 16:37:18 -0700 (PDT) Subject: Re: [PATCH v3] Optimize memory_xfer_partial for remote To: Don Breazeal , gdb-patches@sourceware.org References: <1467326424-139115-1-git-send-email-donb@codesourcery.com> From: Pedro Alves Message-ID: <339ce1ec-0551-a44f-9f39-c7e0f378a250@palves.net> Date: Thu, 30 Jun 2016 23:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1467326424-139115-1-git-send-email-donb@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00566.txt.bz2 On 06/30/2016 11:40 PM, Don Breazeal wrote: > Hi Pedro, > Here is v3 of the patch. Differences from v2 include returning > ULONGEST_MAX instead of 4096 from the default target function > and using TARGET_DEFAULT_RETURN instead of TARGET_DEFAULT_FUNCTION > in the definition of to_get_memory_xfer_limit. > > I re-ran the testsuite with native and native-gdbserver and saw no > regressions. I also verified that the behavior of the memory transfers > was as expected for the remote and native targets. > > Does this one look good-to-go? Yes, looks good. Thanks, Pedro Alves