Re: Re: [PATCH] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)

Re: Re: [PATCH] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)

[KARTHIKVENKATESH BHAT]

Hi,
Thanks. Please find the modified ChangeLog-

Index: gdb/ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.14697
diff -u -p -r1.14697 ChangeLog
--- gdb/ChangeLog	25 Sep 2012 12:48:52 -0000	1.14697
+++ gdb/ChangeLog	25 Sep 2012 13:51:46 -0000
@@ -1,3 +1,7 @@
+2012-09-25  Karthik Bhat  <kv.bhat@samsung.com>
+	
+	* arm-tdep.c (arm_skip_prologue): Extending support for LLVM compiler. 
+
 2012-09-25  Siddhesh Poyarekar  <siddhesh@redhat.com>
 
 	* ada-valprint.c (ada_val_print_1): Eliminate single-use



Index: gdb/arm-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-tdep.c,v
retrieving revision 1.367
diff -u -p -r1.367 arm-tdep.c
--- gdb/arm-tdep.c	22 Aug 2012 19:47:56 -0000	1.367
+++ gdb/arm-tdep.c	25 Sep 2012 13:51:52 -0000
@@ -1400,7 +1400,7 @@ arm_skip_prologue (struct gdbarch *gdbar
       if (post_prologue_pc
 	  && (s == NULL
 	      || s->producer == NULL
-	      || strncmp (s->producer, "GNU ", sizeof ("GNU ") - 1) == 0))
+	      || strncmp (s->producer, "GNU ", sizeof ("GNU ") - 1) == 0 || strncmp (s->producer, "clang ", sizeof ("clang ") - 1) == 0))
 	return post_prologue_pc;
 
       if (post_prologue_pc != 0)


Thanks 
Karthik

------- Original Message -------
Sender : H.J. Lu<hjl.tools@gmail.com>
Date : Sep 25, 2012 22:49 (GMT+09:00)
Title : Re: [PATCH] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)

On Tue, Sep 25, 2012 at 6:45 AM, KARTHIKVENKATESH BHAT
wrote:
> Hi,
> Please find the fix for Bug #14419 (http://sourceware.org/bugzilla/show_bug.cgi?id=14419). Prologue not set properly in case the binary is compiled with LLVM compiler.
> Clang  similar to gcc guarantees a line note before and after the prologue.
> Extending GDB to support binaries compiled with LLVM so that prologue_end is set properly.
>
> Index: gdb/ChangeLog
> ===================================================================
> RCS file: /cvs/src/src/gdb/ChangeLog,v
> retrieving revision 1.14697
> diff -u -p -r1.14697 ChangeLog
> --- gdb/ChangeLog       25 Sep 2012 12:48:52 -0000      1.14697
> +++ gdb/ChangeLog       25 Sep 2012 13:34:52 -0000
> @@ -1,3 +1,7 @@
> +2012-09-25  Karthik Bhat  
> +
> +       * alpha-tdep.c (arm_skip_prologue): Extending support for LLVM compiler.
              "^^ Wrong file name.

-- 
H.J.

Re: Re: [PATCH] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)

[KARTHIKVENKATESH BHAT]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=windows-1252, Size: 4031 bytes --]

Hi
Thanks for the input. I have modified the formating in the code.
Unfortunetly i'm not able to create write-enable cvs workspace for GDB to commit the changes.

Creation of workspace fails with log -

kv.bhat@karthikb-ubuntu:~/OpenSourceProject/GDBSvn$ cvs -d :ext:kvbhat@sourceware.org:/cvs/src co gdb
ssh: connect to host sourceware.org port 22: Connection timed out
cvs [checkout aborted]: end of file from server (consult above messages if any)

Seems to be a public key problem -

Please find my public key -

kv.bhat@karthikb-ubuntu:~/.ssh$ cat ~/.ssh/id_rsa.pub 

ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC/71wN/R4tEkl/HTbMHPPmwDfes6ZoIXWd9s2GMLBwlUNtynjMko/o5algzqxLDf+sHowe1oBCTAQYOnCETei1XGKvn0sY5j2BrqXU8CYpiucnjTq+vTvSJDHeFFA4S4KbHcTErMbM1q5Z/WgMVUM7IWgRnoO8/izbYMB1+l2x+GvG+k3lAB29LOmmf3l0zmG4FRvinokReW3dueo7xySes9/o5daYH7xS+pPPXz7KxRpSpGsV5ktYo1V2TQbB7vRmhfMOcw+VM2iwa74kynZKYEu4h0yt44pl/yzVE1skjiMvPG734TvdaGaum0xeYXBZb6owc+st6Voi6bZ4BTTj kv.bhat@samsung.com


Is it possible for one of the maintainers to commit this patch on our behalf while the above issue is resolved? 


cvs diff: Diffing .
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.14699
diff -u -p -r1.14699 ChangeLog
--- ChangeLog 26 Sep 2012 07:52:44 -0000 1.14699
+++ ChangeLog 26 Sep 2012 10:12:09 -0000
@@ -1,3 +1,7 @@
+2012-09-26  Karthik Bhat  <kv.bhat@samsung.com>
+
+ * arm-tdep.c (arm_skip_prologue): Extending support for LLVM compiler. 
+
 2012-09-26  Siddhesh Poyarekar  <siddhesh@redhat.com>
 
  * amd64-tdep.c (amd64_return_value): Use TYPE_LENGTH directly.
 
 
 
Index: arm-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-tdep.c,v
retrieving revision 1.367
diff -u -p -r1.367 arm-tdep.c
--- arm-tdep.c 22 Aug 2012 19:47:56 -0000 1.367
+++ arm-tdep.c 26 Sep 2012 10:12:11 -0000
@@ -1400,7 +1400,8 @@ arm_skip_prologue (struct gdbarch *gdbar
       if (post_prologue_pc
    && (s == NULL
        || s->producer == NULL
-       || strncmp (s->producer, "GNU ", sizeof ("GNU ") - 1) == 0))
+       || strncmp (s->producer, "GNU ", sizeof ("GNU ") - 1) == 0 
+       || strncmp (s->producer, "clang ", sizeof ("clang ") - 1) == 0))
  return post_prologue_pc;
 
       if (post_prologue_pc != 0)



I would be very grateful if you could.

Thanks and Regards
Karthik



------- Original Message -------
Sender : Joel Brobecker<brobecker@adacore.com>
Date : Sep 26, 2012 00:49 (GMT+09:00)
Title : Re: [PATCH] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)

Karthik,

Thanks for the fix.

> +2012-09-25  Karthik Bhat  
> + 
> + * alpha-tdep.c (arm_skip_prologue): Extending support for LLVM compiler. 
Wrong filename. The patch looks good and is OK to commit provided
you fix the formatting issue outlined below.

Do you have a copyright assignment on file? This patch is small enough
that it can be accepted without one, but if you are planing on
contributing more changes, having one would become necessary.
Let me know if you need to get started on the paperwork.

> Index: gdb/arm-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/arm-tdep.c,v
> retrieving revision 1.367
> diff -u -p -r1.367 arm-tdep.c
> --- gdb/arm-tdep.c 22 Aug 2012 19:47:56 -0000 1.367
> +++ gdb/arm-tdep.c 25 Sep 2012 13:34:54 -0000
> @@ -1400,7 +1400,7 @@ arm_skip_prologue (struct gdbarch *gdbar
>        if (post_prologue_pc
>     && (s == NULL
>         || s->producer == NULL
> -       || strncmp (s->producer, "GNU ", sizeof ("GNU ") - 1) == 0))
> +       || strncmp (s->producer, "GNU ", sizeof ("GNU ") - 1) == 0 || strncmp (s->producer, "clang ", sizeof ("clang ") - 1) == 0))

Please move the addition || condition on the next line, properly aligned
with the others.

-- 
Joel\x16º&Öéj×!zÊÞ¶êç÷9êX¬µªÜ†\a[¥«\…ë