From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10874 invoked by alias); 26 Sep 2012 11:11:38 -0000 Received: (qmail 10858 invoked by uid 22791); 26 Sep 2012 11:11:36 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM,KHOP_RCVD_UNTRUST,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mailout2.samsung.com (HELO mailout2.samsung.com) (203.254.224.25) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Sep 2012 11:11:20 +0000 Received: from epcpsbge3.samsung.com (epcpsbge3 [203.254.230.13]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MAY00004F2C2G00@mailout2.samsung.com> for gdb-patches@sourceware.org; Wed, 26 Sep 2012 20:11:18 +0900 (KST) Received: from epcpsbge3.samsung.com ( [172.20.52.123]) by epcpsbge3.samsung.com (EPCPMTA) with SMTP id 51.E9.03840.6D2E2605; Wed, 26 Sep 2012 20:11:18 +0900 (KST) Received: from epextmailer03 ( [203.254.219.153]) by epcpsbge3.samsung.com (EPCPMTA) with SMTP id 31.E9.03840.6D2E2605; Wed, 26 Sep 2012 20:11:18 +0900 (KST) Date: Wed, 26 Sep 2012 11:11:00 -0000 From: KARTHIKVENKATESH BHAT Subject: Re: Re: [PATCH] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419) To: "gdb-patches@sourceware.org" Reply-to: kv.bhat@samsung.com MIME-version: 1.0 X-MTR: 20120926110804866@kv.bhat Msgkey: 20120926110804866@kv.bhat X-EPLocale: en_US.windows-1252 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-EPTrCode: X-EPTrName: X-MLAttribute: X-RootMTR: 20120926110804866@kv.bhat X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N Content-transfer-encoding: base64 Content-type: text/plain; charset=windows-1252 MIME-version: 1.0 Message-id: <31167206.296221348657878098.JavaMail.weblogic@epml01> DLP-Filter: Pass X-CFilter-Loop: Reflected Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00578.txt.bz2 SGkNClRoYW5rcyBmb3IgdGhlIGlucHV0LiBJIGhhdmUgbW9kaWZpZWQgdGhl IGZvcm1hdGluZyBpbiB0aGUgY29kZS4NClVuZm9ydHVuZXRseSBpJ20gbm90 IGFibGUgdG8gY3JlYXRlIHdyaXRlLWVuYWJsZSBjdnMgd29ya3NwYWNlIGZv ciBHREIgdG8gY29tbWl0IHRoZSBjaGFuZ2VzLg0KDQpDcmVhdGlvbiBvZiB3 b3Jrc3BhY2UgZmFpbHMgd2l0aCBsb2cgLQ0KDQprdi5iaGF0QGthcnRoaWti LXVidW50dTp+L09wZW5Tb3VyY2VQcm9qZWN0L0dEQlN2biQgY3ZzIC1kIDpl eHQ6a3ZiaGF0QHNvdXJjZXdhcmUub3JnOi9jdnMvc3JjIGNvIGdkYg0Kc3No OiBjb25uZWN0IHRvIGhvc3Qgc291cmNld2FyZS5vcmcgcG9ydCAyMjogQ29u bmVjdGlvbiB0aW1lZCBvdXQNCmN2cyBbY2hlY2tvdXQgYWJvcnRlZF06IGVu ZCBvZiBmaWxlIGZyb20gc2VydmVyIChjb25zdWx0IGFib3ZlIG1lc3NhZ2Vz IGlmIGFueSkNCg0KU2VlbXMgdG8gYmUgYSBwdWJsaWMga2V5IHByb2JsZW0g LQ0KDQpQbGVhc2UgZmluZCBteSBwdWJsaWMga2V5IC0NCg0Ka3YuYmhhdEBr YXJ0aGlrYi11YnVudHU6fi8uc3NoJCBjYXQgfi8uc3NoL2lkX3JzYS5wdWIg DQoNCnNzaC1yc2EgQUFBQUIzTnphQzF5YzJFQUFBQURBUUFCQUFBQkFRQy83 MXdOL1I0dEVrbC9IVGJNSFBQbXdEZmVzNlpvSVhXZDlzMkdNTEJ3bFVOdHlu ak1rby9vNWFsZ3pxeExEZitzSG93ZTFvQkNUQVFZT25DRVRlaTFYR0t2bjBz WTVqMkJycVhVOENZcGl1Y25qVHErdlR2U0pESGVGRkE0UzRLYkhjVEVyTWJN MXE1Wi9XZ01WVU03SVdnUm5vTzgvaXpiWU1CMStsMngrR3ZHK2szbEFCMjlM T21tZjNsMHptRzRGUnZpbm9rUmVXM2R1ZW83eHlTZXM5L281ZGFZSDd4Uytw UFBYejdLeFJwU3BHc1Y1a3RZbzFWMlRRYkI3dlJtaGZNT2N3K1ZNMml3YTc0 a3luWktZRXU0aDB5dDQ0cGwveXpWRTFza2ppTXZQRzczNFR2ZGFHYXVtMHhl WVhCWmI2b3djK3N0NlZvaTZiWjRCVFRqIGt2LmJoYXRAc2Ftc3VuZy5jb20N Cg0KDQpJcyBpdCBwb3NzaWJsZSBmb3Igb25lIG9mIHRoZSBtYWludGFpbmVy cyB0byBjb21taXQgdGhpcyBwYXRjaCBvbiBvdXIgYmVoYWxmIHdoaWxlIHRo ZSBhYm92ZSBpc3N1ZSBpcyByZXNvbHZlZD8gDQoNCg0KY3ZzIGRpZmY6IERp ZmZpbmcgLg0KSW5kZXg6IENoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQ0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvQ2hhbmdlTG9nLHYN CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNDY5OQ0KZGlmZiAtdSAtcCAtcjEu MTQ2OTkgQ2hhbmdlTG9nDQotLS0gQ2hhbmdlTG9nIDI2IFNlcCAyMDEyIDA3 OjUyOjQ0IC0wMDAwIDEuMTQ2OTkNCisrKyBDaGFuZ2VMb2cgMjYgU2VwIDIw MTIgMTA6MTI6MDkgLTAwMDANCkBAIC0xLDMgKzEsNyBAQA0KKzIwMTItMDkt MjYgIEthcnRoaWsgQmhhdCAgPGt2LmJoYXRAc2Ftc3VuZy5jb20+DQorDQor ICogYXJtLXRkZXAuYyAoYXJtX3NraXBfcHJvbG9ndWUpOiBFeHRlbmRpbmcg c3VwcG9ydCBmb3IgTExWTSBjb21waWxlci4gDQorDQogMjAxMi0wOS0yNiAg U2lkZGhlc2ggUG95YXJla2FyICA8c2lkZGhlc2hAcmVkaGF0LmNvbT4NCiAN CiAgKiBhbWQ2NC10ZGVwLmMgKGFtZDY0X3JldHVybl92YWx1ZSk6IFVzZSBU WVBFX0xFTkdUSCBkaXJlY3RseS4NCiANCiANCiANCkluZGV4OiBhcm0tdGRl cC5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2cy9z cmMvc3JjL2dkYi9hcm0tdGRlcC5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24g MS4zNjcNCmRpZmYgLXUgLXAgLXIxLjM2NyBhcm0tdGRlcC5jDQotLS0gYXJt LXRkZXAuYyAyMiBBdWcgMjAxMiAxOTo0Nzo1NiAtMDAwMCAxLjM2Nw0KKysr IGFybS10ZGVwLmMgMjYgU2VwIDIwMTIgMTA6MTI6MTEgLTAwMDANCkBAIC0x NDAwLDcgKzE0MDAsOCBAQCBhcm1fc2tpcF9wcm9sb2d1ZSAoc3RydWN0IGdk YmFyY2ggKmdkYmFyDQogICAgICAgaWYgKHBvc3RfcHJvbG9ndWVfcGMNCiAg ICAmJiAocyA9PSBOVUxMDQogICAgICAgIHx8IHMtPnByb2R1Y2VyID09IE5V TEwNCi0gICAgICAgfHwgc3RybmNtcCAocy0+cHJvZHVjZXIsICJHTlUgIiwg c2l6ZW9mICgiR05VICIpIC0gMSkgPT0gMCkpDQorICAgICAgIHx8IHN0cm5j bXAgKHMtPnByb2R1Y2VyLCAiR05VICIsIHNpemVvZiAoIkdOVSAiKSAtIDEp ID09IDAgDQorICAgICAgIHx8IHN0cm5jbXAgKHMtPnByb2R1Y2VyLCAiY2xh bmcgIiwgc2l6ZW9mICgiY2xhbmcgIikgLSAxKSA9PSAwKSkNCiAgcmV0dXJu IHBvc3RfcHJvbG9ndWVfcGM7DQogDQogICAgICAgaWYgKHBvc3RfcHJvbG9n dWVfcGMgIT0gMCkNCg0KDQoNCkkgd291bGQgYmUgdmVyeSBncmF0ZWZ1bCBp ZiB5b3UgY291bGQuDQoNClRoYW5rcyBhbmQgUmVnYXJkcw0KS2FydGhpaw0K DQoNCg0KLS0tLS0tLSBPcmlnaW5hbCBNZXNzYWdlIC0tLS0tLS0NClNlbmRl ciA6IEpvZWwgQnJvYmVja2VyPGJyb2JlY2tlckBhZGFjb3JlLmNvbT4NCkRh dGUgOiBTZXAgMjYsIDIwMTIgMDA6NDkgKEdNVCswOTowMCkNClRpdGxlIDog UmU6IFtQQVRDSF0gUHJvbG9ndWUgbm90IHNldCBwcm9wZXJseSBmb3IgYmlu YXJpZXMgY29tcGlsZWQgd2l0aCBMTFZNIGNvbXBpbGVyIChCdWcgIzE0NDE5 KQ0KDQpLYXJ0aGlrLA0KDQpUaGFua3MgZm9yIHRoZSBmaXguDQoNCj4gKzIw MTItMDktMjUgIEthcnRoaWsgQmhhdCAgDQo+ICsgDQo+ICsgKiBhbHBoYS10 ZGVwLmMgKGFybV9za2lwX3Byb2xvZ3VlKTogRXh0ZW5kaW5nIHN1cHBvcnQg Zm9yIExMVk0gY29tcGlsZXIuIA0KV3JvbmcgZmlsZW5hbWUuIFRoZSBwYXRj aCBsb29rcyBnb29kIGFuZCBpcyBPSyB0byBjb21taXQgcHJvdmlkZWQNCnlv dSBmaXggdGhlIGZvcm1hdHRpbmcgaXNzdWUgb3V0bGluZWQgYmVsb3cuDQoN CkRvIHlvdSBoYXZlIGEgY29weXJpZ2h0IGFzc2lnbm1lbnQgb24gZmlsZT8g VGhpcyBwYXRjaCBpcyBzbWFsbCBlbm91Z2gNCnRoYXQgaXQgY2FuIGJlIGFj Y2VwdGVkIHdpdGhvdXQgb25lLCBidXQgaWYgeW91IGFyZSBwbGFuaW5nIG9u DQpjb250cmlidXRpbmcgbW9yZSBjaGFuZ2VzLCBoYXZpbmcgb25lIHdvdWxk IGJlY29tZSBuZWNlc3NhcnkuDQpMZXQgbWUga25vdyBpZiB5b3UgbmVlZCB0 byBnZXQgc3RhcnRlZCBvbiB0aGUgcGFwZXJ3b3JrLg0KDQo+IEluZGV4OiBn ZGIvYXJtLXRkZXAuYw0KPiA9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQo+IFJD UyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2FybS10ZGVwLmMsdg0KPiByZXRy aWV2aW5nIHJldmlzaW9uIDEuMzY3DQo+IGRpZmYgLXUgLXAgLXIxLjM2NyBh cm0tdGRlcC5jDQo+IC0tLSBnZGIvYXJtLXRkZXAuYyAyMiBBdWcgMjAxMiAx OTo0Nzo1NiAtMDAwMCAxLjM2Nw0KPiArKysgZ2RiL2FybS10ZGVwLmMgMjUg U2VwIDIwMTIgMTM6MzQ6NTQgLTAwMDANCj4gQEAgLTE0MDAsNyArMTQwMCw3 IEBAIGFybV9za2lwX3Byb2xvZ3VlIChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXIN Cj4gICAgICAgIGlmIChwb3N0X3Byb2xvZ3VlX3BjDQo+ICAgICAmJiAocyA9 PSBOVUxMDQo+ICAgICAgICAgfHwgcy0+cHJvZHVjZXIgPT0gTlVMTA0KPiAt ICAgICAgIHx8IHN0cm5jbXAgKHMtPnByb2R1Y2VyLCAiR05VICIsIHNpemVv ZiAoIkdOVSAiKSAtIDEpID09IDApKQ0KPiArICAgICAgIHx8IHN0cm5jbXAg KHMtPnByb2R1Y2VyLCAiR05VICIsIHNpemVvZiAoIkdOVSAiKSAtIDEpID09 IDAgfHwgc3RybmNtcCAocy0+cHJvZHVjZXIsICJjbGFuZyAiLCBzaXplb2Yg KCJjbGFuZyAiKSAtIDEpID09IDApKQ0KDQpQbGVhc2UgbW92ZSB0aGUgYWRk aXRpb24gfHwgY29uZGl0aW9uIG9uIHRoZSBuZXh0IGxpbmUsIHByb3Blcmx5 IGFsaWduZWQNCndpdGggdGhlIG90aGVycy4NCg0KLS0gDQpKb2Vs >From gdb-patches-return-94856-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Sep 26 11:17:44 2012 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 15376 invoked by alias); 26 Sep 2012 11:17:43 -0000 Received: (qmail 15361 invoked by uid 22791); 26 Sep 2012 11:17:42 -0000 X-SWARE-Spam-Status: No, hits=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Sep 2012 11:17:26 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8QBHO2T005847 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 26 Sep 2012 07:17:24 -0400 Received: from spoyarek (spoyarek.pnq.redhat.com [10.65.192.188]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8QBHMVw021892; Wed, 26 Sep 2012 07:17:23 -0400 Date: Wed, 26 Sep 2012 11:17:00 -0000 From: Siddhesh Poyarekar To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [commit][obv] Use TYPE_LENGTH directly where possible Message-ID: <20120926164641.61b38fb1@spoyarek> In-Reply-To: <20120926105205.GB4335@adacore.com> References: <20120926132621.5f45acb7@spoyarek> <20120926094227.GA4335@adacore.com> <20120926152740.0900e9b7@spoyarek> <20120926105205.GB4335@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org X-SW-Source: 2012-09/txt/msg00579.txt.bz2 Content-length: 1048 On Wed, 26 Sep 2012 12:52:06 +0200, Joel wrote: > I know it makes no functional difference, but it does make a > noticeable difference in terms of maintenance, IMO. And I have in > fact been silently grumbling about your patches being labeled > "obvious" when in fact I do not consider them obvious. But I have let > them go, because it wasn't significant enough that I felt I needed to > talk about it. > > But this part of this patch in particular did catch my attention, and > I feel that we need to discuss it. I think this goes in the wrong > direction, and it would be better to just change the variable > (constant???) type, rather than duplicate the expression everywhere. > I don't have a strong opinion on this, and if other maintainers are ok > with it, then OK. But in the meantime, I think the previous version > was better. OK, I'll revert this patch if anyone else objects as well. And thanks for responding - I wouldn't have known otherwise and would have assumed that these changes are generally acceptable. Regards, Siddhesh