[RFA + doc] Document unimplemented "-break-insert -r"

[RFA + doc] Document unimplemented "-break-insert -r"

[Keith Seitz]

[-- Attachment #1: Type: text/plain, Size: 2199 bytes --]

Hi,

While poking around -break-insert this afternoon, I noticed that the 
"-r" option is completely unimplemented, but is mentioned (briefly) in 
the example for the command's documentation in the User Manual.

This patch removes mention of the "-r" option (comments it out), removes 
mention of "rbreak" from the corresponding list of "GDB commands", and 
adds a PR number to the XFAILed tests in the test suite. [The sources do 
not otherwise even mention this "-r" option.]

I'm including the doc inline and the testsuite patch as an attachment to 
avoid any line-wrap issues.

Keith

testsuite/ChangeLog
2012-06-20  Keith Seitz  <keiths@redhat.com>

	PR mi/14270
	* gdb.mi/mi-break.exp (test_rbreak_creation_and_listing):
	Add bugzilla numbers to XFAILed tests.

doc/ChangeLog
2012-06-20  Keith Seitz  <keiths@redhat.com>

	PR mi/14270
	* gdb.texinfo (GDB/MI Breakpoint Commands): Remove "-r" option
	from example.  Remove "rbreak" from list of corresponding
	gdb commands.

Index: doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.977
diff -u -p -r1.977 gdb.texinfo
--- doc/gdb.texinfo	20 Jun 2012 20:11:06 -0000	1.977
+++ doc/gdb.texinfo	20 Jun 2012 20:19:20 -0000
@@ -28088,7 +28088,7 @@ Note: this format is open to change.
  @subsubheading @value{GDBN} Command

  The corresponding @value{GDBN} commands are @samp{break}, @samp{tbreak},
-@samp{hbreak}, @samp{thbreak}, and @samp{rbreak}.
+@samp{hbreak}, and @samp{thbreak}. @c and @samp{rbreak}.

  @subsubheading Example

@@ -28117,11 +28117,11 @@ bkpt=@{number="2",type="breakpoint",disp
  addr="0x00010774",func="foo",file="recursive2.c",
  fullname="/home/foo/recursive2.c",line="11",times="0"@}]@}
  (gdb)
--break-insert -r foo.*
-~int foo(int, int);
-^done,bkpt=@{number="3",addr="0x00010774",file="recursive2.c,
-"fullname="/home/foo/recursive2.c",line="11",times="0"@}
-(gdb)
+@c -break-insert -r foo.*
+@c ~int foo(int, int);
+@c ^done,bkpt=@{number="3",addr="0x00010774",file="recursive2.c,
+@c "fullname="/home/foo/recursive2.c",line="11",times="0"@}
+@c (gdb)
  @end smallexample

  @subheading The @code{-break-list} Command

[-- Attachment #2: remove-r-from-break-insert.patch --]
[-- Type: text/x-patch, Size: 2587 bytes --]

Index: testsuite/gdb.mi/mi-break.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-break.exp,v
retrieving revision 1.33
diff -u -p -r1.33 mi-break.exp
--- testsuite/gdb.mi/mi-break.exp	4 Jan 2012 08:17:54 -0000	1.33
+++ testsuite/gdb.mi/mi-break.exp	20 Jun 2012 20:19:20 -0000
@@ -121,27 +121,27 @@ proc test_rbreak_creation_and_listing {}
     # -break-insert -r .*llee
     # -break-list
 
-    setup_xfail "*-*-*"
+    setup_xfail "*-*-*" mi/14270
     mi_gdb_test "122-break-insert -r main" \
              "122\\^done,bkpt=\{number=\"5\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_main_body\"\}" \
              "break-insert -r operation"
 
-    setup_xfail "*-*-*"
+    setup_xfail "*-*-*" mi/14270
     mi_gdb_test "133-break-insert -r callee2" \
              "133\\^done,bkpt=\{number=\"6\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_callee2_body\"\}" \
              "insert breakpoint with regexp callee2"
 
-    setup_xfail "*-*-*"
+    setup_xfail "*-*-*" mi/14270
     mi_gdb_test "144-break-insert -r callee" \
 	    "144\\^done,bkpt=\{number=\"7\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_callee1_body\"\},bkpt=\{number=\"8\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_callee2_body\"\},bkpt=\{number=\"9\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_callee3_body\"\},bkpt=\{number=\"10\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_callee4_body\"\}" \
              "insert breakpoint with regexp callee"
 
-    setup_xfail "*-*-*"
+    setup_xfail "*-*-*" mi/14270
     mi_gdb_test "155-break-insert -r \.\*llee" \
 	    "155\\^done,bkpt=\{number=\"11\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_callee1_body\"\},bkpt=\{number=\"12\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_callee2_body\"\},bkpt=\{number=\"13\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_callee3_body\"\},bkpt=\{number=\"14\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_callee4_body\"\}" \
              "insert breakpoint with regexp .*llee"
 
-    setup_xfail "*-*-*"
+    setup_xfail "*-*-*" mi/14270
     mi_gdb_test "166-break-list" \
 	    "1\\\^done,BreakpointTable=\{nr_rows=\".\",nr_cols=\".\",hdr=\\\[\{width=\".*\",alignment=\".*\",col_name=\"number\",colhdr=\"Num\"\}.*colhdr=\"Type\".*colhdr=\"Disp\".*colhdr=\"Enb\".*colhdr=\"Address\".*colhdr=\"What\".*\\\],body=\\\[bkpt=\{number=\"5\",type=\"breakpoint\",disp=\"keep\",enabled=\"y\",addr=\"$hex\",func=\"main\",file=\".*basics.c\",line=\"$line_main_body\",times=\"0\"\},.*\}\\\]\}" \
                 "list of breakpoints"

Re: [RFA + doc] Document unimplemented "-break-insert -r"

[Yao Qi]

On Wednesday 20 June 2012 13:29:46 Keith Seitz wrote:
> -    setup_xfail "*-*-*"
> +    setup_xfail "*-*-*" mi/14270

Keith,
It is better to use "setup_kfail" here, because these fails are caused by 
GDB's limitation rather other other components' limitation.

-- 
Yao (齐尧)

Re: [RFA + doc] Document unimplemented "-break-insert -r"

[Eli Zaretskii]

> Date: Wed, 20 Jun 2012 13:29:46 -0700
> From: Keith Seitz <keiths@redhat.com>
> 
> 	PR mi/14270
> 	* gdb.texinfo (GDB/MI Breakpoint Commands): Remove "-r" option
> 	from example.  Remove "rbreak" from list of corresponding
> 	gdb commands.

OK for this part, thanks.

Re: [RFA + doc] Document unimplemented "-break-insert -r"

[Tom Tromey]

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> 	PR mi/14270
Keith> 	* gdb.mi/mi-break.exp (test_rbreak_creation_and_listing):
Keith> 	Add bugzilla numbers to XFAILed tests.

Ok with the kfail change that Yao suggested.

Tom

Re: [RFA + doc] Document unimplemented "-break-insert -r"

[Keith Seitz]

On 06/22/2012 07:08 AM, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz<keiths@redhat.com>  writes:
>
> Keith>  	PR mi/14270
> Keith>  	* gdb.mi/mi-break.exp (test_rbreak_creation_and_listing):
> Keith>  	Add bugzilla numbers to XFAILed tests.
>
> Ok with the kfail change that Yao suggested.

Committed with those changes. Thank you, Tom, Yao, and Eli for your 
review and comments.

Keith