From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15345 invoked by alias); 20 Jun 2012 20:30:23 -0000 Received: (qmail 15325 invoked by uid 22791); 20 Jun 2012 20:30:21 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jun 2012 20:29:49 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5KKTn96003042 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 20 Jun 2012 16:29:49 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q5KKTk8r030055 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 20 Jun 2012 16:29:48 -0400 Message-ID: <4FE232BA.6030808@redhat.com> Date: Wed, 20 Jun 2012 20:30:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: "gdb-patches@sourceware.org ml" Subject: [RFA + doc] Document unimplemented "-break-insert -r" Content-Type: multipart/mixed; boundary="------------050201000803040506010404" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00647.txt.bz2 This is a multi-part message in MIME format. --------------050201000803040506010404 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 2199 Hi, While poking around -break-insert this afternoon, I noticed that the "-r" option is completely unimplemented, but is mentioned (briefly) in the example for the command's documentation in the User Manual. This patch removes mention of the "-r" option (comments it out), removes mention of "rbreak" from the corresponding list of "GDB commands", and adds a PR number to the XFAILed tests in the test suite. [The sources do not otherwise even mention this "-r" option.] I'm including the doc inline and the testsuite patch as an attachment to avoid any line-wrap issues. Keith testsuite/ChangeLog 2012-06-20 Keith Seitz PR mi/14270 * gdb.mi/mi-break.exp (test_rbreak_creation_and_listing): Add bugzilla numbers to XFAILed tests. doc/ChangeLog 2012-06-20 Keith Seitz PR mi/14270 * gdb.texinfo (GDB/MI Breakpoint Commands): Remove "-r" option from example. Remove "rbreak" from list of corresponding gdb commands. Index: doc/gdb.texinfo =================================================================== RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v retrieving revision 1.977 diff -u -p -r1.977 gdb.texinfo --- doc/gdb.texinfo 20 Jun 2012 20:11:06 -0000 1.977 +++ doc/gdb.texinfo 20 Jun 2012 20:19:20 -0000 @@ -28088,7 +28088,7 @@ Note: this format is open to change. @subsubheading @value{GDBN} Command The corresponding @value{GDBN} commands are @samp{break}, @samp{tbreak}, -@samp{hbreak}, @samp{thbreak}, and @samp{rbreak}. +@samp{hbreak}, and @samp{thbreak}. @c and @samp{rbreak}. @subsubheading Example @@ -28117,11 +28117,11 @@ bkpt=@{number="2",type="breakpoint",disp addr="0x00010774",func="foo",file="recursive2.c", fullname="/home/foo/recursive2.c",line="11",times="0"@}]@} (gdb) --break-insert -r foo.* -~int foo(int, int); -^done,bkpt=@{number="3",addr="0x00010774",file="recursive2.c, -"fullname="/home/foo/recursive2.c",line="11",times="0"@} -(gdb) +@c -break-insert -r foo.* +@c ~int foo(int, int); +@c ^done,bkpt=@{number="3",addr="0x00010774",file="recursive2.c, +@c "fullname="/home/foo/recursive2.c",line="11",times="0"@} +@c (gdb) @end smallexample @subheading The @code{-break-list} Command --------------050201000803040506010404 Content-Type: text/x-patch; name="remove-r-from-break-insert.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="remove-r-from-break-insert.patch" Content-length: 2587 Index: testsuite/gdb.mi/mi-break.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-break.exp,v retrieving revision 1.33 diff -u -p -r1.33 mi-break.exp --- testsuite/gdb.mi/mi-break.exp 4 Jan 2012 08:17:54 -0000 1.33 +++ testsuite/gdb.mi/mi-break.exp 20 Jun 2012 20:19:20 -0000 @@ -121,27 +121,27 @@ proc test_rbreak_creation_and_listing {} # -break-insert -r .*llee # -break-list - setup_xfail "*-*-*" + setup_xfail "*-*-*" mi/14270 mi_gdb_test "122-break-insert -r main" \ "122\\^done,bkpt=\{number=\"5\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_main_body\"\}" \ "break-insert -r operation" - setup_xfail "*-*-*" + setup_xfail "*-*-*" mi/14270 mi_gdb_test "133-break-insert -r callee2" \ "133\\^done,bkpt=\{number=\"6\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_callee2_body\"\}" \ "insert breakpoint with regexp callee2" - setup_xfail "*-*-*" + setup_xfail "*-*-*" mi/14270 mi_gdb_test "144-break-insert -r callee" \ "144\\^done,bkpt=\{number=\"7\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_callee1_body\"\},bkpt=\{number=\"8\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_callee2_body\"\},bkpt=\{number=\"9\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_callee3_body\"\},bkpt=\{number=\"10\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_callee4_body\"\}" \ "insert breakpoint with regexp callee" - setup_xfail "*-*-*" + setup_xfail "*-*-*" mi/14270 mi_gdb_test "155-break-insert -r \.\*llee" \ "155\\^done,bkpt=\{number=\"11\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_callee1_body\"\},bkpt=\{number=\"12\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_callee2_body\"\},bkpt=\{number=\"13\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_callee3_body\"\},bkpt=\{number=\"14\",addr=\"$hex\",file=\".*basics.c\",line=\"$line_callee4_body\"\}" \ "insert breakpoint with regexp .*llee" - setup_xfail "*-*-*" + setup_xfail "*-*-*" mi/14270 mi_gdb_test "166-break-list" \ "1\\\^done,BreakpointTable=\{nr_rows=\".\",nr_cols=\".\",hdr=\\\[\{width=\".*\",alignment=\".*\",col_name=\"number\",colhdr=\"Num\"\}.*colhdr=\"Type\".*colhdr=\"Disp\".*colhdr=\"Enb\".*colhdr=\"Address\".*colhdr=\"What\".*\\\],body=\\\[bkpt=\{number=\"5\",type=\"breakpoint\",disp=\"keep\",enabled=\"y\",addr=\"$hex\",func=\"main\",file=\".*basics.c\",line=\"$line_main_body\",times=\"0\"\},.*\}\\\]\}" \ "list of breakpoints" --------------050201000803040506010404--