Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/8] watch_command_1: Fix dangling frame access
Date: Thu, 13 Apr 2017 15:26:00 -0000	[thread overview]
Message-ID: <322ca8f4-a3b5-9b3c-950b-d8ea61d6c45e@redhat.com> (raw)
In-Reply-To: <86efwwabxb.fsf@gmail.com>

On 04/13/2017 10:34 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
> 
>> -  if (exp_valid_block && frame)
>> +  if (exp_valid_block && wp_frame)
> 
> if (exp_valid_block != NULL && wp_frame != NULL)
> 
> Patch is good to me.

Thanks!  I did that change, and pushed patches 1-6, up until the
one that add cdtors to struct inferior.

I went ahead because last my non-POD + memset detector flagged 
struct inferior, and also because I saw that Sergio's C++fy
environ patch was adding yet another non-POD member to
struct inferior.

Thanks,
Pedro Alves


  reply	other threads:[~2017-04-13 15:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-11 23:51 [PATCH 0/8] Fix removing inferiors from within "thread apply" commands Pedro Alves
2017-04-11 23:51 ` [PATCH 2/8] Fix follow-fork latent bug Pedro Alves
2017-04-13  9:58   ` Yao Qi
2017-04-13 12:09     ` Pedro Alves
2017-04-13 15:33       ` Yao Qi
2017-04-11 23:51 ` [PATCH 1/8] watch_command_1: Fix dangling frame access Pedro Alves
2017-04-13  9:34   ` Yao Qi
2017-04-13 15:26     ` Pedro Alves [this message]
2017-04-11 23:51 ` [PATCH 6/8] Make inferior a class with cdtors, and use new/delete Pedro Alves
2017-04-13 10:24   ` Yao Qi
2017-04-11 23:51 ` [PATCH 8/8] Fix removing inferiors from within "thread apply" commands Pedro Alves
2017-04-13 11:33   ` Yao Qi
2017-04-13 12:22     ` Pedro Alves
2017-04-13 14:49       ` Pedro Alves
2017-04-19  8:23         ` Yao Qi
2017-04-19 12:15           ` Pedro Alves
2017-04-19 12:20             ` Pedro Alves
2017-04-13 15:31       ` Yao Qi
2017-04-11 23:51 ` [PATCH 7/8] Make inferior::detaching a bool, and introduce scoped_restore::release() Pedro Alves
2017-04-11 23:51 ` [PATCH 3/8] C++fy thread_apply_all_command Pedro Alves
2017-04-13 10:06   ` Yao Qi
2017-04-11 23:56 ` [PATCH 5/8] GC inferior.c:init_inferior_list Pedro Alves
2017-04-13 10:10   ` Yao Qi
2017-04-11 23:56 ` [PATCH 4/8] Improve coverage of the PR threads/13217 regression test Pedro Alves
2017-04-13 10:09   ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=322ca8f4-a3b5-9b3c-950b-d8ea61d6c45e@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox