From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/8] Fix follow-fork latent bug
Date: Thu, 13 Apr 2017 09:58:00 -0000 [thread overview]
Message-ID: <86a87kaasz.fsf@gmail.com> (raw)
In-Reply-To: <1491954673-29172-3-git-send-email-palves@redhat.com> (Pedro Alves's message of "Wed, 12 Apr 2017 00:51:07 +0100")
Pedro Alves <palves@redhat.com> writes:
> - old_chain = save_inferior_ptid ();
> - save_current_program_space ();
> + old_chain = save_current_space_and_thread ();
>
> inferior_ptid = child_ptid;
> add_thread (inferior_ptid);
> + set_current_inferior (child_inf);
> child_inf->symfile_flags = SYMFILE_NO_READ;
Can we set up child thread_info inferior and pspace first, and then,
call switch_to_thread_no_regs to switch them in one go?
>
> /* If this is a vfork child, then the address-space is
> @@ -631,6 +631,7 @@ holding the child stopped. Try \"set detach-on-fork\" or \
>
> inferior_ptid = child_ptid;
> add_thread (inferior_ptid);
> + set_current_inferior (child_inf);
--
Yao (齐尧)
next prev parent reply other threads:[~2017-04-13 9:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 23:51 [PATCH 0/8] Fix removing inferiors from within "thread apply" commands Pedro Alves
2017-04-11 23:51 ` [PATCH 1/8] watch_command_1: Fix dangling frame access Pedro Alves
2017-04-13 9:34 ` Yao Qi
2017-04-13 15:26 ` Pedro Alves
2017-04-11 23:51 ` [PATCH 2/8] Fix follow-fork latent bug Pedro Alves
2017-04-13 9:58 ` Yao Qi [this message]
2017-04-13 12:09 ` Pedro Alves
2017-04-13 15:33 ` Yao Qi
2017-04-11 23:51 ` [PATCH 6/8] Make inferior a class with cdtors, and use new/delete Pedro Alves
2017-04-13 10:24 ` Yao Qi
2017-04-11 23:51 ` [PATCH 8/8] Fix removing inferiors from within "thread apply" commands Pedro Alves
2017-04-13 11:33 ` Yao Qi
2017-04-13 12:22 ` Pedro Alves
2017-04-13 14:49 ` Pedro Alves
2017-04-19 8:23 ` Yao Qi
2017-04-19 12:15 ` Pedro Alves
2017-04-19 12:20 ` Pedro Alves
2017-04-13 15:31 ` Yao Qi
2017-04-11 23:51 ` [PATCH 7/8] Make inferior::detaching a bool, and introduce scoped_restore::release() Pedro Alves
2017-04-11 23:51 ` [PATCH 3/8] C++fy thread_apply_all_command Pedro Alves
2017-04-13 10:06 ` Yao Qi
2017-04-11 23:56 ` [PATCH 5/8] GC inferior.c:init_inferior_list Pedro Alves
2017-04-13 10:10 ` Yao Qi
2017-04-11 23:56 ` [PATCH 4/8] Improve coverage of the PR threads/13217 regression test Pedro Alves
2017-04-13 10:09 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a87kaasz.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox