From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4645 invoked by alias); 13 Apr 2017 15:26:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4610 invoked by uid 89); 13 Apr 2017 15:26:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f49.google.com Received: from mail-wm0-f49.google.com (HELO mail-wm0-f49.google.com) (74.125.82.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Apr 2017 15:26:13 +0000 Received: by mail-wm0-f49.google.com with SMTP id w64so114600310wma.0 for ; Thu, 13 Apr 2017 08:26:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=l2XbuLh5G39L2WOYXc7u0mzcbV4aVTdBAZ2yqwaAETE=; b=aXh63yVZJDDJQwbrZIybnr4KyVO2gnKhehGExzbF2J1363J8MUoYFrnGah5LrBs+MQ V373aTD4RP7WJLizaoUuiinDq7eWpX7tSEtI5DsUxSYDh3Wbo4yLIARjOd93FhC9yLau bWyTRkdpcCWnl4ZkpItCz5gAxID+PlNIvkDXMn7EFSTyMdJ4YnVMaNVNrqLnv2AkDGOX KnE+wDx3SEybQ/KyQWEG6xeVOqWeZXV/pa5/yg2RCENewKi9LbdKbDiKuARWgfBCmJpf 0Cc4Tcv3d0q4mBTGikFo43ian1uTCEWJfLLvVqigSJDwmzJ/bBWzlTF+xbB8i6649ICT hChQ== X-Gm-Message-State: AN3rC/48VYOYGaoSNLU+1JfTZj9IELQ6sOki5346jeFVLr7LuzyU0VW1 ZeVomDnOnHZmQTqnJJ68Zg== X-Received: by 10.28.66.77 with SMTP id p74mr26449645wma.107.1492097173211; Thu, 13 Apr 2017 08:26:13 -0700 (PDT) Received: from [192.168.0.101] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id w12sm29923859wra.21.2017.04.13.08.26.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Apr 2017 08:26:12 -0700 (PDT) Subject: Re: [PATCH 1/8] watch_command_1: Fix dangling frame access To: Yao Qi References: <1491954673-29172-1-git-send-email-palves@redhat.com> <1491954673-29172-2-git-send-email-palves@redhat.com> <86efwwabxb.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <322ca8f4-a3b5-9b3c-950b-d8ea61d6c45e@redhat.com> Date: Thu, 13 Apr 2017 15:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <86efwwabxb.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00434.txt.bz2 On 04/13/2017 10:34 AM, Yao Qi wrote: > Pedro Alves writes: > >> - if (exp_valid_block && frame) >> + if (exp_valid_block && wp_frame) > > if (exp_valid_block != NULL && wp_frame != NULL) > > Patch is good to me. Thanks! I did that change, and pushed patches 1-6, up until the one that add cdtors to struct inferior. I went ahead because last my non-POD + memset detector flagged struct inferior, and also because I saw that Sergio's C++fy environ patch was adding yet another non-POD member to struct inferior. Thanks, Pedro Alves